Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-SNOW: Fix two issues in insertRows API #602

Merged
merged 40 commits into from
Oct 17, 2023
Merged

Conversation

sfc-gh-tzhang
Copy link
Contributor

This PR contains two fixes in the current insertRows logic:

  • We can't thrown any exception when ON_ERROR=CONTINUE, since it will cause duplicate data if we insert rows into the buffer but not updating the offset token
  • Update the row buffer only if the rows are inserted successfully for ON_ERROR=SKIP_BATCH

@sfc-gh-tzhang sfc-gh-tzhang requested review from a team as code owners October 17, 2023 00:17
@sfc-gh-tzhang sfc-gh-tzhang merged commit 570894c into master Oct 17, 2023
10 checks passed
@sfc-gh-tzhang sfc-gh-tzhang deleted the tzhang-si-random branch October 17, 2023 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants