Skip to content

Commit

Permalink
minor change
Browse files Browse the repository at this point in the history
  • Loading branch information
sfc-gh-tzhang committed Mar 26, 2024
1 parent f25a8aa commit af3a61f
Show file tree
Hide file tree
Showing 6 changed files with 16 additions and 191 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -716,7 +716,7 @@ public HttpPost generateStreamingIngestPostRequest(
* @param payload POST request payload
* @param endPoint REST API endpoint
* @param message error message if there are failures during HTTP building
* @param queryParameters
* @param queryParameters POST request query parameters
* @return URI for the POST request
*/
public HttpPost generateStreamingIngestPostRequest(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,7 @@ void setStatusCode(Long statusCode) {
}

@JsonProperty("status_code")
@Override
Long getStatusCode() {
return this.statusCode;
}
Expand Down

This file was deleted.

Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
/*
* Copyright (c) 2021 Snowflake Computing Inc. All rights reserved.
* Copyright (c) 2024 Snowflake Computing Inc. All rights reserved.
*/

package net.snowflake.ingest.streaming.internal;

import com.fasterxml.jackson.annotation.JsonProperty;

/** Response to the OpenChannelRequest */
/** Response to the open channel request to open a rowset api channel */
class OpenRowsetChannelResponse extends StreamingIngestResponse {
private String message;
private String continuationToken;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,21 +12,22 @@
import net.snowflake.ingest.streaming.SnowflakeStreamingIngestChannel;
import net.snowflake.ingest.utils.Logging;

/** The implementation for Rowset API channel */
public class SnowflakeStreamingIngestChannelRowset implements SnowflakeStreamingIngestChannel {

private static final Logging logger = new Logging(SnowflakeStreamingIngestChannelRowset.class);

private String dbName;
private final String dbName;

private String schemaName;
private final String schemaName;

private String pipeName;
private final String pipeName;

private String tableName;
private final String tableName;

private String name;
private final String name;

private String fullyQualifiedName;
private final String fullyQualifiedName;

private boolean isClosed;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -384,6 +384,11 @@ public SnowflakeStreamingIngestChannel openChannel(OpenChannelRequest request) {
}
}

/**
* This function builds and sends an open channel request that opens a rowset api channel against
* a pipe or table. It will return a {@link SnowflakeStreamingIngestChannel} object if succeeded,
* otherwise it will throw an exception with failure HTTP response code.
*/
private SnowflakeStreamingIngestChannel openRowsetApiChannel(OpenChannelRequest request)
throws IngestResponseException, IOException {
Map<Object, Object> payload = new HashMap<>();
Expand Down

0 comments on commit af3a61f

Please sign in to comment.