Skip to content

Commit

Permalink
Iteration 2: Addresses Tobys comments
Browse files Browse the repository at this point in the history
  • Loading branch information
sfc-gh-tjones committed Sep 20, 2023
1 parent e38a7e5 commit 9ea17bd
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -256,7 +256,9 @@ InsertValidationResponse insertRows(
String getLatestCommittedOffsetToken();

/**
* Gets the table schema associated with this channel
* Gets the table schema associated with this channel. Note that this is the table schema at the
* time of a channel open event. The schema may be changed on the Snowflake side in which case
* this will continue to show an old schema version until the channel is re-opened.
*
* @return map representing Column Name -> Column Properties
*/
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@

/**
* Class that encapsulates column properties. These are the same properties showed in the output of
* <a href="https://docs.snowflake.com/en/sql-reference/sql/show-columns">SHOW COLUMNS</a>
* <a href="https://docs.snowflake.com/en/sql-reference/sql/show-columns">SHOW COLUMNS</a>. Note
* that this is slightly different than the internal column metadata used elsewhere in this SDK.
*/
public class ColumnProperties {
private String type;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -126,11 +126,11 @@ class SnowflakeStreamingIngestChannelInternal<T> implements SnowflakeStreamingIn
this::collectRowSize,
channelState,
new ClientBufferParameters(owningClient));
this.tableColumns = new HashMap<>();
logger.logInfo(
"Channel={} created for table={}",
this.channelFlushContext.getName(),
this.channelFlushContext.getTableName());
this.tableColumns = new HashMap<>();
}

/**
Expand Down

0 comments on commit 9ea17bd

Please sign in to comment.