Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1836910 bump pyopenssl #2110

Merged
merged 1 commit into from
Dec 2, 2024
Merged

SNOW-1836910 bump pyopenssl #2110

merged 1 commit into from
Dec 2, 2024
+2 −1

Conversation

sfc-gh-mkeller
Copy link
Collaborator

@sfc-gh-mkeller sfc-gh-mkeller commented Dec 2, 2024 •
edited
Loading

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-1836910

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency

  3. Please describe how your code solves the related issue.

    In this PR I raise the minimum pyopenssl version we require.

  4. (Optional) PR for stored-proc connector:

@sfc-gh-mkeller sfc-gh-mkeller added the DO_NOT_PORT_CHANGES_TO_SP Add this label when changes in this PR do not need to be port to SP connector label Dec 2, 2024
@sfc-gh-dszmolka sfc-gh-dszmolka mentioned this pull request Dec 2, 2024
Closed
@sfc-gh-mkeller sfc-gh-mkeller linked an issue Dec 2, 2024 that may be closed by this pull request
SNOW-1831724: AttributeError: module 'lib' has no attribute 'X509_V_FLAG_NOTIFY_POLICY' error on import with PyOpenSSL<22.1.0 installed #2109
Closed
sfc-gh-fhe
sfc-gh-fhe approved these changes Dec 2, 2024
View reviewed changes
Copy link

@sfc-gh-fhe sfc-gh-fhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@sfc-gh-mkeller sfc-gh-mkeller merged commit fef06c3 into main Dec 2, 2024
95 of 96 checks passed
@sfc-gh-mkeller sfc-gh-mkeller deleted the mkeller/SNOW-1836910/bump-pyopenssl branch December 2, 2024 20:49
@github-actions github-actions bot locked and limited conversation to collaborators Dec 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-fhe sfc-gh-fhe sfc-gh-fhe approved these changes

Assignees
No one assigned
Labels
DO_NOT_PORT_CHANGES_TO_SP Add this label when changes in this PR do not need to be port to SP connector
Projects
None yet
Milestone
No milestone
2 participants
@sfc-gh-mkeller @sfc-gh-fhe