Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1507212 create an interface for Snowflake restful class(es) #1983

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

SNOW-1507212 create an interface for Snowflake restful class(es) #1983

wants to merge 1 commit into from
+154 −7

Conversation

sfc-gh-zyao
Copy link

Description

  • create an interface SnowflakeRestfulInterface
    • both the client side restful class and the server side restful class shall conform to this interface
  • update the type annotation to use SnowflakeRestfulInterface instead of the concrete class SnowflakeRestful Testing

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fulfills SNOW-1507212

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency

  3. Please describe how your code solves the related issue.

    (see the description)

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 27, 2024 •
edited
Loading

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@sfc-gh-zyao sfc-gh-zyao marked this pull request as draft June 27, 2024 21:40
@sfc-gh-zyao
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

@sfc-gh-zyao sfc-gh-zyao force-pushed the zyao-SNOW-1507212-setup-restful-interface-for-public-connector branch from f7fe991 to 1a6afda Compare June 27, 2024 21:51
@sfc-gh-zyao
SNOW-1507212 create an interface for Snowflake restful class(es)
b7d8d36 
Description
- create an interface SnowflakeRestfulInterface
  - both the client side restful class and the server side restful class shall conform to this interface
- update the type annotation to use SnowflakeRestfulInterface instead of the concrete class SnowflakeRestful
Testing
@sfc-gh-zyao sfc-gh-zyao force-pushed the zyao-SNOW-1507212-setup-restful-interface-for-public-connector branch from 1a6afda to b7d8d36 Compare June 27, 2024 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sfc-gh-zyao