Fix default config location resolution on Windows OS (#2017)

DESCRIPTION.md

@@ -10,6 +10,7 @@ Source code is also available at: https://github.com/snowflakedb/snowflake-conne
 
 - v3.12.1(TBD)
   - Fixed a bug that session token is logged when renewing session.
+  - Use `pathlib` instead of `os` for default config file location resolution.
   - Fixed a bug that disabling client telemetry does not work.
 
 - v3.12.0(July 24,2024)

src/snowflake/connector/sf_dirs.py

@@ -31,12 +31,12 @@ def _resolve_platform_dirs() -> PlatformDirsProto:
         "appname": "snowflake",
         "appauthor": False,
     }
-    snowflake_home = os.path.expanduser(
+    snowflake_home = pathlib.Path(
         os.environ.get("SNOWFLAKE_HOME", "~/.snowflake/"),
-    )
-    if os.path.exists(snowflake_home):
+    ).expanduser()
+    if snowflake_home.exists():
         return SFPlatformDirs(
-            snowflake_home,
+            str(snowflake_home),
             **platformdir_kwargs,
         )
     else:

test/unit/test_configmanager.py

@@ -522,9 +522,11 @@ def test_sf_dirs(tmp_path, version):
 
 
 def test_config_file_resolution_sfdirs_default():
-    default_loc = os.path.expanduser("~/.snowflake")
-    existed_before = os.path.exists(default_loc)
-    os.makedirs(default_loc, exist_ok=True)
+    from pathlib import Path
+
+    default_loc = Path("~/.snowflake").expanduser()
+    existed_before = default_loc.exists()
+    default_loc.mkdir(exist_ok=True)
     try:
         assert isinstance(_resolve_platform_dirs(), SFPlatformDirs)
     finally: