Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1789759: NodeJS Support GCS region specific endpoint (Axios) #990

Merged
merged 4 commits into from
Dec 20, 2024

Conversation

sfc-gh-ext-simba-jy
Copy link
Collaborator

Description

Please explain the changes you made here.

Checklist

  • Format code according to the existing code style (run npm run lint:check -- CHANGED_FILES and fix problems in changed code)
  • Create tests which fail without the change (if possible)
  • Make all tests (unit and integration) pass (npm run test:unit and npm run test:integration)
  • Extend the types in index.d.ts file (if necessary)
  • Extend the README / documentation and ensure is properly displayed (if necessary)
  • Provide JIRA issue id (if possible) or GitHub issue id in commit message

@sfc-gh-ext-simba-jy sfc-gh-ext-simba-jy marked this pull request as ready for review December 17, 2024 20:03
@sfc-gh-ext-simba-jy sfc-gh-ext-simba-jy requested a review from a team as a code owner December 17, 2024 20:03
Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.92%. Comparing base (0aaa740) to head (8a13cfc).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #990   +/-   ##
=======================================
  Coverage   88.92%   88.92%           
=======================================
  Files          72       72           
  Lines        6950     6954    +4     
=======================================
+ Hits         6180     6184    +4     
  Misses        770      770           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfc-gh-ext-simba-jy sfc-gh-ext-simba-jy merged commit 817d82f into master Dec 20, 2024
40 of 43 checks passed
@sfc-gh-ext-simba-jy sfc-gh-ext-simba-jy deleted the SNOW-1789759v2 branch December 20, 2024 18:18
@github-actions github-actions bot locked and limited conversation to collaborators Dec 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants