Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumped up the NodeJS Driver MAJOR version from 1.15.0 to 2.0.0 #981

Merged
merged 4 commits into from
Dec 11, 2024

Conversation

sfc-gh-pmotacki
Copy link
Collaborator

Description

Please explain the changes you made here.

Checklist

  • Format code according to the existing code style (run npm run lint:check -- CHANGED_FILES and fix problems in changed code)
  • Create tests which fail without the change (if possible)
  • Make all tests (unit and integration) pass (npm run test:unit and npm run test:integration)
  • Extend the types in index.d.ts file (if necessary)
  • Extend the README / documentation and ensure is properly displayed (if necessary)
  • Provide JIRA issue id (if possible) or GitHub issue id in commit message

@sfc-gh-pmotacki sfc-gh-pmotacki requested a review from a team as a code owner December 6, 2024 14:42
Copy link

codecov bot commented Dec 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.88%. Comparing base (d7eed90) to head (9b5b3aa).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #981      +/-   ##
==========================================
- Coverage   88.91%   88.88%   -0.03%     
==========================================
  Files          72       72              
  Lines        6944     6944              
==========================================
- Hits         6174     6172       -2     
- Misses        770      772       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@sfc-gh-dprzybysz sfc-gh-dprzybysz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you update the note in Readme that we are supporting GCS regional endpoint starting from version 2.0.0?

@sfc-gh-dszmolka sfc-gh-dszmolka changed the title Bumped up the NodeJS Driver MINOR version from 1.15.0 to 2.0.0 Bumped up the NodeJS Driver MAJOR version from 1.15.0 to 2.0.0 Dec 9, 2024
@sfc-gh-pmotacki sfc-gh-pmotacki merged commit d8a22b4 into master Dec 11, 2024
56 of 59 checks passed
@sfc-gh-pmotacki sfc-gh-pmotacki deleted the bump_node_version branch December 11, 2024 04:52
@github-actions github-actions bot locked and limited conversation to collaborators Dec 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants