Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1843504 - Testing resubmitting requests using request id #979

Merged
merged 6 commits into from
Dec 5, 2024
Merged

SNOW-1843504 - Testing resubmitting requests using request id #979

merged 6 commits into from
Dec 5, 2024

Conversation

sfc-gh-pmotacki
Copy link
Collaborator

@sfc-gh-pmotacki sfc-gh-pmotacki commented Dec 3, 2024 •
edited
Loading

Description

Node.js - Testing resubmitting requests using request id

Checklist

  • Format code according to the existing code style (run npm run lint:check -- CHANGED_FILES and fix problems in changed code)
  • Create tests which fail without the change (if possible)
  • Make all tests (unit and integration) pass (npm run test:unit and npm run test:integration)
  • Extend the README / documentation and ensure is properly displayed (if necessary)
  • Provide JIRA issue id (if possible) or GitHub issue id in commit message

@sfc-gh-pmotacki sfc-gh-pmotacki requested a review from a team as a code owner December 3, 2024 13:21
@codecov Codecov
Copy link

codecov bot commented Dec 3, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.98%. Comparing base (2ec8d4a) to head (a704459).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #979      +/-   ##
==========================================
+ Coverage   88.61%   88.98%   +0.36%     
==========================================
  Files          69       69              
  Lines        6764     6764              
==========================================
+ Hits         5994     6019      +25     
+ Misses        770      745      -25

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfc-gh-pmotacki sfc-gh-pmotacki force-pushed the SNOW-1843504 branch 5 times, most recently from 1eb3209 to 10c46ef Compare December 4, 2024 08:59
sfc-gh-dprzybysz
sfc-gh-dprzybysz reviewed Dec 4, 2024
View reviewed changes
test/integration/testExecute.js Outdated Show resolved Hide resolved
test/integration/testExecute.js Outdated Show resolved Hide resolved
test/integration/testExecute.js Show resolved Hide resolved
test/integration/testExecute.js Outdated Show resolved Hide resolved
@sfc-gh-pmotacki sfc-gh-pmotacki merged commit cf7b3a3 into master Dec 5, 2024
56 of 57 checks passed
@sfc-gh-pmotacki sfc-gh-pmotacki deleted the SNOW-1843504 branch December 5, 2024 09:52
@github-actions github-actions bot locked and limited conversation to collaborators Dec 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-pfus sfc-gh-pfus sfc-gh-pfus approved these changes

@sfc-gh-dprzybysz sfc-gh-dprzybysz sfc-gh-dprzybysz approved these changes

@sfc-gh-fpawlowski sfc-gh-fpawlowski Awaiting requested review from sfc-gh-fpawlowski

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-pmotacki @sfc-gh-dprzybysz @sfc-gh-pfus