Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1739611 add automated tests for okta, oauth and keypair #976

Merged
merged 4 commits into from
Dec 4, 2024

Conversation

sfc-gh-akolodziejczyk
Copy link
Contributor

@sfc-gh-akolodziejczyk sfc-gh-akolodziejczyk commented Nov 29, 2024

Description

SNOW-1739611

  1. Extracted reusable code from external browser tests to authTestsBaseClass.js
  2. Added tests for Oauth and Okta

Checklist

  • Format code according to the existing code style (run npm run lint:check -- CHANGED_FILES and fix problems in changed code)
  • Create tests which fail without the change (if possible)
  • Make all tests (unit and integration) pass (npm run test:unit and npm run test:integration)
  • Extend the README / documentation and ensure is properly displayed (if necessary)
  • Provide JIRA issue id (if possible) or GitHub issue id in commit message

@sfc-gh-akolodziejczyk sfc-gh-akolodziejczyk marked this pull request as ready for review November 29, 2024 13:16
@sfc-gh-akolodziejczyk sfc-gh-akolodziejczyk requested a review from a team as a code owner November 29, 2024 13:16
Copy link

codecov bot commented Nov 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.95%. Comparing base (e6f30aa) to head (4ca6b2b).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #976   +/-   ##
=======================================
  Coverage   88.95%   88.95%           
=======================================
  Files          69       69           
  Lines        6754     6754           
=======================================
  Hits         6008     6008           
  Misses        746      746           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfc-gh-akolodziejczyk sfc-gh-akolodziejczyk changed the title SNOW-1739611 add automated tests for okta and oauth SNOW-1739611 add automated tests for okta, oauth and keypair Dec 2, 2024
@sfc-gh-akolodziejczyk sfc-gh-akolodziejczyk merged commit f6d50ea into master Dec 4, 2024
59 checks passed
@sfc-gh-akolodziejczyk sfc-gh-akolodziejczyk deleted the SNOW-1799619-other-methods branch December 4, 2024 09:23
@github-actions github-actions bot locked and limited conversation to collaborators Dec 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants