Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1789759: NodeJS Support GCS region specific endpoint #975

Merged
merged 10 commits into from
Dec 5, 2024

Conversation

sfc-gh-ext-simba-jy
Copy link
Collaborator

Description

Please explain the changes you made here.

  • Add a condition to check the value of UseS3RegionalUrl in S3_util
  • Added a condition to check the value of useRegionalUrl and the region is me-central2

Checklist

  • Format code according to the existing code style (run npm run lint:check -- CHANGED_FILES and fix problems in changed code)
  • Create tests which fail without the change (if possible)
  • Make all tests (unit and integration) pass (npm run test:unit and npm run test:integration)
  • Extend the README / documentation and ensure is properly displayed (if necessary)
  • Provide JIRA issue id (if possible) or GitHub issue id in commit message

@sfc-gh-ext-simba-jy sfc-gh-ext-simba-jy requested a review from a team as a code owner November 28, 2024 22:56
Copy link

codecov bot commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.95%. Comparing base (f6d50ea) to head (c5838f7).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #975      +/-   ##
==========================================
+ Coverage   88.93%   88.95%   +0.01%     
==========================================
  Files          69       69              
  Lines        6754     6764      +10     
==========================================
+ Hits         6007     6017      +10     
  Misses        747      747              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

lib/file_transfer_agent/gcs_util.js Outdated Show resolved Hide resolved
lib/file_transfer_agent/gcs_util.js Outdated Show resolved Hide resolved
lib/file_transfer_agent/s3_util.js Outdated Show resolved Hide resolved
lib/file_transfer_agent/s3_util.js Show resolved Hide resolved
Copy link
Collaborator

@sfc-gh-pmotacki sfc-gh-pmotacki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix what is mentioned by @sfc-gh-dprzybysz. After that -> LGTM.

lib/file_transfer_agent/gcs_util.js Outdated Show resolved Hide resolved
Copy link
Collaborator

@sfc-gh-pmotacki sfc-gh-pmotacki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfc-gh-pmotacki sfc-gh-pmotacki merged commit 2ec8d4a into master Dec 5, 2024
57 checks passed
@sfc-gh-pmotacki sfc-gh-pmotacki deleted the SNOW-1789759 branch December 5, 2024 08:35
@github-actions github-actions bot locked and limited conversation to collaborators Dec 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants