-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SNOW-1825719 - setting proxy port if default was skipped during parsing #972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #972 +/- ##
==========================================
+ Coverage 88.90% 88.95% +0.05%
==========================================
Files 69 69
Lines 6748 6754 +6
==========================================
+ Hits 5999 6008 +9
+ Misses 749 746 -3 ☔ View full report in Codecov by Sentry. |
sfc-gh-pmotacki
requested review from
sfc-gh-dprzybysz,
sfc-gh-dheyman and
sfc-gh-fpawlowski
November 26, 2024 07:23
sfc-gh-dprzybysz
approved these changes
Nov 26, 2024
sfc-gh-astachowski
approved these changes
Nov 26, 2024
sfc-gh-dszmolka
previously requested changes
Nov 26, 2024
sfc-gh-dheyman
approved these changes
Nov 26, 2024
…ng parsing" This reverts commit c32d13c.
sfc-gh-pmotacki
force-pushed
the
SNOW-1825719
branch
from
November 26, 2024 15:45
ba8b70d
to
dbad20b
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please explain the changes you made here.
Checklist
npm run lint:check -- CHANGED_FILES
and fix problems in changed code)npm run test:unit
andnpm run test:integration
)