Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1825719 - setting proxy port if default was skipped during parsing #972

Merged
merged 6 commits into from
Nov 27, 2024

Conversation

sfc-gh-pmotacki
Copy link
Collaborator

@sfc-gh-pmotacki sfc-gh-pmotacki commented Nov 25, 2024

Description

Please explain the changes you made here.

Checklist

  • Format code according to the existing code style (run npm run lint:check -- CHANGED_FILES and fix problems in changed code)
  • Create tests which fail without the change (if possible)
  • Make all tests (unit and integration) pass (npm run test:unit and npm run test:integration)
  • Extend the README / documentation and ensure is properly displayed (if necessary)
  • Provide JIRA issue id (if possible) or GitHub issue id in commit message

@sfc-gh-pmotacki sfc-gh-pmotacki requested a review from a team as a code owner November 25, 2024 16:51
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.95%. Comparing base (871b10d) to head (dbad20b).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #972      +/-   ##
==========================================
+ Coverage   88.90%   88.95%   +0.05%     
==========================================
  Files          69       69              
  Lines        6748     6754       +6     
==========================================
+ Hits         5999     6008       +9     
+ Misses        749      746       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

lib/util.js Outdated Show resolved Hide resolved
lib/util.js Outdated Show resolved Hide resolved
lib/util.js Outdated Show resolved Hide resolved
lib/util.js Outdated Show resolved Hide resolved
@sfc-gh-pmotacki sfc-gh-pmotacki merged commit 753aa3d into master Nov 27, 2024
59 checks passed
@sfc-gh-pmotacki sfc-gh-pmotacki deleted the SNOW-1825719 branch November 27, 2024 07:52
@github-actions github-actions bot locked and limited conversation to collaborators Nov 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants