Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1346233 execute automated external browser tests #970

Merged
merged 8 commits into from
Nov 28, 2024

Conversation

sfc-gh-akolodziejczyk
Copy link
Contributor

@sfc-gh-akolodziejczyk sfc-gh-akolodziejczyk commented Nov 22, 2024

Description

SNOW-1346233

  1. Authentication tests will be stored in a separate directory test/authentication
  2. Credentials are stored in separate gpg file.
  3. Authentication tests will be executed on Jenkins in parallel to other tests.
  4. Authentication tests are executed inside the docker container which is created from images available in the internal repository. It includes code responsible for filling in browser credentials. Code for building the image will be stored in a separate repository

Checklist

  • Format code according to the existing code style (run npm run lint:check -- CHANGED_FILES and fix problems in changed code)
  • Create tests which fail without the change (if possible)
  • Make all tests (unit and integration) pass (npm run test:unit and npm run test:integration)
  • Extend the README / documentation and ensure is properly displayed (if necessary)
  • Provide JIRA issue id (if possible) or GitHub issue id in commit message

@sfc-gh-akolodziejczyk sfc-gh-akolodziejczyk force-pushed the SNOW-1799619 branch 5 times, most recently from c399741 to 04d76da Compare November 25, 2024 11:08
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.92%. Comparing base (753aa3d) to head (d3c81a2).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #970      +/-   ##
==========================================
- Coverage   88.95%   88.92%   -0.03%     
==========================================
  Files          69       69              
  Lines        6754     6754              
==========================================
- Hits         6008     6006       -2     
- Misses        746      748       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfc-gh-akolodziejczyk sfc-gh-akolodziejczyk marked this pull request as ready for review November 25, 2024 12:57
@sfc-gh-akolodziejczyk sfc-gh-akolodziejczyk requested a review from a team as a code owner November 25, 2024 12:57
@sfc-gh-akolodziejczyk sfc-gh-akolodziejczyk changed the title execute automated external browser tests SNOW-1346233 execute automated external browser tests Nov 28, 2024
@sfc-gh-akolodziejczyk sfc-gh-akolodziejczyk merged commit 599e55c into master Nov 28, 2024
58 of 59 checks passed
@sfc-gh-akolodziejczyk sfc-gh-akolodziejczyk deleted the SNOW-1799619 branch November 28, 2024 14:08
@github-actions github-actions bot locked and limited conversation to collaborators Nov 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants