Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1524258: Implement GCM encryption #966

Merged
merged 11 commits into from
Nov 21, 2024

Conversation

sfc-gh-dheyman
Copy link
Collaborator

@sfc-gh-dheyman sfc-gh-dheyman commented Nov 19, 2024

Description

SNOW-1524258: Implement GCM encryption

Checklist

  • Format code according to the existing code style (run npm run lint:check -- CHANGED_FILES and fix problems in changed code)
  • Create tests which fail without the change (if possible)
  • Make all tests (unit and integration) pass (npm run test:unit and npm run test:integration)
  • Extend the README / documentation and ensure is properly displayed (if necessary)
  • Provide JIRA issue id (if possible) or GitHub issue id in commit message

@sfc-gh-dheyman sfc-gh-dheyman requested a review from a team as a code owner November 19, 2024 13:58
lib/file_transfer_agent/encrypt_util.js Outdated Show resolved Hide resolved
lib/file_transfer_agent/encrypt_util.js Outdated Show resolved Hide resolved
lib/file_transfer_agent/encrypt_util.js Outdated Show resolved Hide resolved
lib/file_transfer_agent/encrypt_util.js Outdated Show resolved Hide resolved
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

Attention: Patch coverage is 95.27559% with 6 lines in your changes missing coverage. Please review.

Project coverage is 88.90%. Comparing base (c4e6edb) to head (6ab4372).

Files with missing lines Patch % Lines
lib/file_transfer_agent/encrypt_util.js 95.27% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #966      +/-   ##
==========================================
- Coverage   88.91%   88.90%   -0.02%     
==========================================
  Files          69       69              
  Lines        6685     6748      +63     
==========================================
+ Hits         5944     5999      +55     
- Misses        741      749       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

lib/file_transfer_agent/encryption_types.js Outdated Show resolved Hide resolved
lib/file_transfer_agent/encrypt_util.js Outdated Show resolved Hide resolved
lib/file_transfer_agent/encrypt_util.js Outdated Show resolved Hide resolved
lib/file_transfer_agent/encrypt_util.js Outdated Show resolved Hide resolved
lib/file_transfer_agent/encrypt_util.js Show resolved Hide resolved
lib/file_transfer_agent/encrypt_util.js Show resolved Hide resolved
lib/file_transfer_agent/encrypt_util.js Outdated Show resolved Hide resolved
lib/file_transfer_agent/encrypt_util.js Outdated Show resolved Hide resolved
test/integration/testEncrypt.js Outdated Show resolved Hide resolved
test/integration/testEncrypt.js Outdated Show resolved Hide resolved
lib/file_transfer_agent/encrypt_util.js Outdated Show resolved Hide resolved
test/integration/testEncrypt.js Outdated Show resolved Hide resolved
test/integration/testEncrypt.js Outdated Show resolved Hide resolved
@sfc-gh-dheyman sfc-gh-dheyman merged commit bada542 into master Nov 21, 2024
57 checks passed
@sfc-gh-dheyman sfc-gh-dheyman deleted the SNOW-1524258-gcm-encryption branch November 21, 2024 12:54
@github-actions github-actions bot locked and limited conversation to collaborators Nov 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants