SNOW-1789666 azure/core-http deprecated #951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azure/core-http transient dependency coming from azure/[email protected] . Starting from azure/[email protected] and above, they migrated their dependency on azure/core-http to azure/core-rest-pipeline
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #951 +/- ##
==========================================
+ Coverage 88.96% 89.20% +0.24%
==========================================
Files 72 72
Lines 6960 6960
==========================================
+ Hits 6192 6209 +17
+ Misses 768 751 -17 ☔ View full report in Codecov by Sentry. |
|
tests on Azure node 14.x are failing, so likely we'll need to wait until we deprecate node:14 |
|
now with release v2.0.0, support for node:14 is dropped. GH tests seem to be successful, but Jenkins looks sick a bit. Waiting for it to recover to have those tests in the green too. |
…mits), as it was released while we were waiting for node:14 deprecation on Snowflake end
sfc-gh-dprzybysz
approved these changes
Dec 20, 2024
sfc-gh-pbulawa
approved these changes
Jan 10, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upon
npm installingsnowflake-sdk, following deprecation warning is emitted:This deprecated dependency on
azure/core-httpcomes transiently from @azure/[email protected]on which we depend with
"@azure/storage-blob": "12.18.x"next version @azure/[email protected] doesn't have this dependency anymore, has
instead. Recommendation per deprecation message is to migrate to
@azure/core-rest-pipeline, which they did per changelog too.Checklist
npm run lint:check -- CHANGED_FILESand fix problems in changed code)npm run test:unitandnpm run test:integration)