Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1694143: Fix sso token authentication #919

Merged
merged 2 commits into from
Oct 1, 2024
Merged

Conversation

sfc-gh-ext-simba-jy
Copy link
Collaborator

@sfc-gh-ext-simba-jy sfc-gh-ext-simba-jy commented Sep 27, 2024

Co-authored-by: @supermacro

Fixes SSO token cache capability introduced in v1.12.0, broken in 1.13.

Description

  • Added clientRequestMFAToken and clientStoreTemporaryCredential options in the index.d.ts file.
  • Fixed the bug about the token caching.

Checklist

  • Format code according to the existing code style (run npm run lint:check -- CHANGED_FILES and fix problems in changed code)
  • Create tests which fail without the change (if possible)
  • Make all tests (unit and integration) pass (npm run test:unit and npm run test:integration)
  • Extend the README / documentation and ensure is properly displayed (if necessary)
  • Provide JIRA issue id (if possible) or GitHub issue id in commit message

@sfc-gh-ext-simba-jy sfc-gh-ext-simba-jy requested a review from a team as a code owner September 27, 2024 02:59
Copy link

codecov bot commented Sep 27, 2024

Codecov Report

Attention: Patch coverage is 28.57143% with 5 lines in your changes missing coverage. Please review.

Project coverage is 88.75%. Comparing base (b624a8f) to head (8b49fb0).

Files with missing lines Patch % Lines
lib/services/sf.js 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #919      +/-   ##
==========================================
- Coverage   88.76%   88.75%   -0.02%     
==========================================
  Files          65       65              
  Lines        6304     6305       +1     
==========================================
  Hits         5596     5596              
- Misses        708      709       +1     
Flag Coverage Δ
88.73% <28.57%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfc-gh-fpawlowski
Copy link
Contributor

Hi, it seems like changes were partially implemented in this PR: #918 - we can add "Co-authored-by: supermacro" tag in the final commit.

@sfc-gh-dszmolka
Copy link
Collaborator

linking related issue: #921

@sfc-gh-dszmolka sfc-gh-dszmolka changed the title Fix sso token authentication SNOW-1694143: Fix sso token authentication Sep 30, 2024
@sfc-gh-ext-simba-jy sfc-gh-ext-simba-jy merged commit 852017f into master Oct 1, 2024
51 of 56 checks passed
@sfc-gh-ext-simba-jy sfc-gh-ext-simba-jy deleted the fixssoauth branch October 1, 2024 01:46
@github-actions github-actions bot locked and limited conversation to collaborators Oct 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants