fix: when err.code is not numeric or doesnot exist take err.response.… #764
Conversation
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
lib/file_transfer_agent/gcs_util.js
Outdated
| @@ -178,7 +178,7 @@ function GCSUtil(httpclient, filestream) { | |||
| encryptionMetadata | |||
| ); | |||
| } catch (err) { | |||
| const errCode = err['code'] ? err['code'] : err.response.status; | |||
| const errCode = !err['code'] || isNaN(err['code']) ? err.response.status : err['code']; | |||
There was a problem hiding this comment.
Hi @naira-petrosyan-m. Thank you for your proposal. I tried to verify your code and in my opinion it could failed on for example boolean true. What do you think about:
!isNaN(err['code']) && !isNaN(parseInt(err['code'])) ? err['code'] : err.response.status ??
There was a problem hiding this comment.
@sfc-gh-pmotacki I just thought that err.code wouldn't be a Boolean value in any case, but sure I can change the condition to include parseInt.
There was a problem hiding this comment.
@sfc-gh-pmotacki fyi I have pushed the update above.
There was a problem hiding this comment.
Thank you @naira-petrosyan-m. The code is correct now. I've run tests on your branch and got failed result. Could you rebase to master branch and verify code using 'npm run lint:check' please.
There was a problem hiding this comment.
@sfc-gh-pmotacki my branch is opened from the "gcpoperationerror" branch, and when rebasing with master it gives a lot of conflicts as when rebasing master into "gcpoperationerror". This is what I get when running the lint checking command.
naira-petrosyan-m
force-pushed
the
bugfix/axios-returning-non-numeric-err-code
branch
from
c8e2e81 to
1665e1a
Compare
|
I have read the CLA Document and I hereby sign the CLA |
* SNOW-1064052 - fix PUT files with wildcards on Windows
|
Hello @naira-petrosyan-m. After detect and fix bug in master branch it is needed to rebase branch with master. Can you rebase please? |
naira-petrosyan-m
force-pushed
the
bugfix/axios-returning-non-numeric-err-code
branch
from
1665e1a to
569af67
Compare
@sfc-gh-pmotacki I have rebased with master |
sfc-gh-pmotacki
merged commit c79d086
into
snowflakedb:gcpoperationerror
|
Thank you one more time @naira-petrosyan-m |
…status instead
Description
GCP thrown err['code'] is a numeric value, while axios.head thrown err['code'] is a string name, e.g. BAD_REQUEST and it has a numeric err.response.status. Change includes checking if there is no err['code'] or it is not numeric take err.response.status otherwise take the err['code'].
Relates to issue SNOW-975540
and PR SNOW-975781
Checklist
npm run lint:check -- CHANGED_FILESand fix problems in changed code)npm run test:unitandnpm run test:integration)