Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert commit of reuse storage clients #747

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

sfc-gh-pmotacki
Copy link
Collaborator

Description

Please explain the changes you made here.

Checklist

  • Format code according to the existing code style (run npm run lint:check -- CHANGED_FILES and fix problems in changed code)
  • Create tests which fail without the change (if possible)
  • Make all tests (unit and integration) pass (npm run test:unit and npm run test:integration)
  • Extend the README / documentation and ensure is properly displayed (if necessary)
  • Provide JIRA issue id (if possible) or GitHub issue id in commit message

@sfc-gh-pmotacki sfc-gh-pmotacki requested a review from a team as a code owner January 9, 2024 09:04
@sfc-gh-pmotacki sfc-gh-pmotacki force-pushed the reuse_storage_clients_revert branch from df868d2 to c97fda1 Compare January 9, 2024 09:07
@sfc-gh-pmotacki sfc-gh-pmotacki force-pushed the reuse_storage_clients_revert branch from c97fda1 to 5f2c778 Compare January 9, 2024 09:09
@sfc-gh-dheyman sfc-gh-dheyman self-requested a review January 9, 2024 09:50
Copy link

codecov bot commented Jan 9, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (dc4536d) 89.75% compared to head (702e560) 89.72%.

❗ Current head 702e560 differs from pull request most recent head 5f2c778. Consider uploading reports for the commit 5f2c778 to get more accurate results

Files Patch % Lines
lib/file_transfer_agent/file_transfer_agent.js 78.57% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #747      +/-   ##
==========================================
- Coverage   89.75%   89.72%   -0.03%     
==========================================
  Files          59       59              
  Lines        5644     5628      -16     
==========================================
- Hits         5066     5050      -16     
  Misses        578      578              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfc-gh-pmotacki sfc-gh-pmotacki force-pushed the reuse_storage_clients_revert branch 2 times, most recently from 702e560 to 5f2c778 Compare January 10, 2024 11:22
@sfc-gh-pmotacki sfc-gh-pmotacki merged commit 75a93fa into master Jan 10, 2024
76 of 90 checks passed
@sfc-gh-pmotacki sfc-gh-pmotacki deleted the reuse_storage_clients_revert branch January 10, 2024 13:20
@github-actions github-actions bot locked and limited conversation to collaborators Jan 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants