Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-959721 TypeError: Converting circular structure to JSON in isValidAsync exception handling #688

Merged
merged 5 commits into from
Nov 8, 2023

Conversation

sfc-gh-dszmolka
Copy link
Collaborator

SNOW-959721, issue 732

Attempt to implement a function for JSON.stringify replacer argument, to handle the 'TypeError: Converting circular structure to JSON' which seems to come in certain cases

@sfc-gh-dszmolka sfc-gh-dszmolka marked this pull request as ready for review November 6, 2023 15:42
@sfc-gh-dszmolka sfc-gh-dszmolka requested a review from a team as a code owner November 6, 2023 15:42
@sfc-gh-dszmolka sfc-gh-dszmolka marked this pull request as draft November 6, 2023 16:57
Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Merging #688 (bc1be96) into master (611fa33) will increase coverage by 0.02%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##           master     #688      +/-   ##
==========================================
+ Coverage   87.74%   87.76%   +0.02%     
==========================================
  Files          61       61              
  Lines        5745     5756      +11     
==========================================
+ Hits         5041     5052      +11     
  Misses        704      704              
Files Coverage Δ
lib/connection/connection.js 86.85% <0.00%> (ø)
lib/util.js 97.08% <90.90%> (-0.54%) ⬇️

... and 1 file with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@sfc-gh-dszmolka sfc-gh-dszmolka marked this pull request as ready for review November 7, 2023 07:21
@sfc-gh-pbulawa sfc-gh-pbulawa merged commit 645faeb into master Nov 8, 2023
42 of 44 checks passed
@sfc-gh-pbulawa sfc-gh-pbulawa deleted the SNOW-959721-circular-reference branch November 8, 2023 08:50
@github-actions github-actions bot locked and limited conversation to collaborators Nov 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants