Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-933240: Use custom httpclient for Okta auth #686

Merged
merged 6 commits into from
Nov 7, 2023

Conversation

sfc-gh-pbulawa
Copy link
Collaborator

Description

Use the SF custom httpclient for the communication with Okta provider.

Checklist

  • Format code according to the existing code style (run npm run lint:check -- CHANGED_FILES and fix problems in changed code)
  • Create tests which fail without the change (if possible)
  • Make all tests (unit and integration) pass (npm run test:unit and npm run test:integration)
  • Extend the README / documentation and ensure is properly displayed (if necessary)
  • Provide JIRA issue id (if possible) or GitHub issue id in commit message

@sfc-gh-pbulawa sfc-gh-pbulawa requested a review from a team as a code owner November 2, 2023 16:20
Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Merging #686 (51f6c6c) into master (97081e3) will decrease coverage by 0.08%.
The diff coverage is 77.41%.

@@            Coverage Diff             @@
##           master     #686      +/-   ##
==========================================
- Coverage   87.80%   87.72%   -0.08%     
==========================================
  Files          61       61              
  Lines        5725     5745      +20     
==========================================
+ Hits         5027     5040      +13     
- Misses        698      705       +7     
Files Coverage Δ
lib/connection/connection.js 86.85% <100.00%> (+0.07%) ⬆️
lib/authentication/authentication.js 67.85% <85.71%> (+6.98%) ⬆️
lib/authentication/auth_okta.js 87.27% <85.71%> (-2.73%) ⬇️
lib/http/base.js 85.22% <55.55%> (-3.39%) ⬇️

... and 1 file with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

Copy link
Collaborator

@sfc-gh-pmotacki sfc-gh-pmotacki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfc-gh-pbulawa sfc-gh-pbulawa merged commit a724e7a into master Nov 7, 2023
41 of 44 checks passed
@sfc-gh-pbulawa sfc-gh-pbulawa deleted the SNOW-933240-okta-auth-http branch November 7, 2023 09:50
@github-actions github-actions bot locked and limited conversation to collaborators Nov 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants