Fix token-request in retry strategy. #685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #685 +/- ##
==========================================
+ Coverage 87.57% 87.75% +0.17%
==========================================
Files 60 60
Lines 5628 5628
==========================================
+ Hits 4929 4939 +10
+ Misses 699 689 -10
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
lib/services/sf.js
Outdated
| 'oldSessionToken': this.tokenInfo.getSessionToken() | ||
| 'oldSessionToken': this.tokenInfo.getSessionToken(), | ||
| data: { | ||
| CLIENT_APP_ID: this.connectionConfig.getClientType(), |
There was a problem hiding this comment.
Maybe you wanted to add in the request header?
sfc-gh-pbulawa
approved these changes
Nov 2, 2023
sfc-gh-pmotacki
force-pushed
the
retry-strategy-fix
branch
from
9a4ec90 to
c00fd86
Compare
sfc-gh-dstempniak
approved these changes
Nov 2, 2023
sfc-gh-pmotacki
force-pushed
the
retry-strategy-fix
branch
from
c00fd86 to
b6b9632
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please explain the changes you made here.
Checklist
npm run lint:check -- CHANGED_FILESand fix problems in changed code)npm run test:unitandnpm run test:integration)