Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-856233 easy logging - not fail on directory search error #680

Merged
merged 2 commits into from
Oct 31, 2023
Merged

SNOW-856233 easy logging - not fail on directory search error #680

merged 2 commits into from
Oct 31, 2023

Conversation

sfc-gh-knozderko
Copy link
Collaborator

Description

Prevent to fail if client config file could not be found because of an unexpected error during the phase of searching in predefined directory. It could happen if for example there is no home folder in the operating system.

Checklist

  • Format code according to the existing code style (run npm run lint:check -- CHANGED_FILES and fix problems in changed code)
  • Create tests which fail without the change (if possible)
  • Make all tests (unit and integration) pass (npm run test:unit and npm run test:integration)
  • Extend the README / documentation and ensure is properly displayed (if necessary)
  • Provide JIRA issue id (if possible) or GitHub issue id in commit message

@sfc-gh-knozderko sfc-gh-knozderko requested a review from a team as a code owner October 30, 2023 14:30
sfc-gh-pmotacki
sfc-gh-pmotacki approved these changes Oct 31, 2023
View reviewed changes
Copy link
Collaborator

@sfc-gh-pmotacki sfc-gh-pmotacki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sfc-gh-knozderko sfc-gh-knozderko merged commit 8bfb622 into master Oct 31, 2023
42 checks passed
@sfc-gh-knozderko sfc-gh-knozderko deleted the SNOW-856233_not_fail_if_dir_search_fails branch October 31, 2023 14:11
@github-actions github-actions bot locked and limited conversation to collaborators Oct 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-pmotacki sfc-gh-pmotacki sfc-gh-pmotacki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-knozderko @sfc-gh-pmotacki