Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-926029: Check for renewing/connecting state when validating a connection #669

Merged
merged 5 commits into from
Oct 19, 2023

Conversation

sfc-gh-ext-simba-lf
Copy link
Collaborator

@sfc-gh-ext-simba-lf sfc-gh-ext-simba-lf commented Oct 16, 2023

Description

Regarding issue 678

The PR checks if a connection is renewing/connecting to determine if it is valid. This can prevent an Already connected error or Connection already in progress error which happens when a user calls the isUp or isValidAsync function and it returns false and the user then tries to connect manually while the connection is already renewing/connecting

Checklist

  • Format code according to the existing code style (run npm run lint:check -- CHANGED_FILES and fix problems in changed code)
  • Create tests which fail without the change (if possible)
  • Make all tests (unit and integration) pass (npm run test:unit and npm run test:integration)
  • Extend the README / documentation and ensure is properly displayed (if necessary)
  • Provide JIRA issue id (if possible) or GitHub issue id in commit message

@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Merging #669 (5fe28f5) into master (bcdcd99) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #669      +/-   ##
==========================================
+ Coverage   87.74%   87.79%   +0.05%     
==========================================
  Files          60       60              
  Lines        5590     5590              
==========================================
+ Hits         4905     4908       +3     
+ Misses        685      682       -3     
Files Coverage Δ
lib/services/sf.js 87.41% <100.00%> (+0.69%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sfc-gh-ext-simba-lf sfc-gh-ext-simba-lf marked this pull request as ready for review October 17, 2023 19:37
@sfc-gh-ext-simba-lf sfc-gh-ext-simba-lf requested a review from a team as a code owner October 17, 2023 19:37
lib/services/sf.js Outdated Show resolved Hide resolved
@sfc-gh-ext-simba-lf sfc-gh-ext-simba-lf changed the title SNOW-926029: Check for stateRenewing when validating a connection SNOW-926029: Check for renewing/connecting state when validating a connection Oct 18, 2023
Copy link
Collaborator

@sfc-gh-pmotacki sfc-gh-pmotacki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfc-gh-ext-simba-lf sfc-gh-ext-simba-lf merged commit 2e711fd into master Oct 19, 2023
7 checks passed
@sfc-gh-ext-simba-lf sfc-gh-ext-simba-lf deleted the SNOW-926029-is-valid-async branch October 19, 2023 17:24
@github-actions github-actions bot locked and limited conversation to collaborators Oct 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants