Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-933278: Add camelCase, eqeqeq and no-sync rules for eslint #662

Conversation

sfc-gh-dprzybysz
Copy link
Collaborator

Description

  • Add camelCase, eqeqeq and no-sync rules for eslint
  • Add samples to the directories to lint
  • Add script showing only lint errors

Checklist

  • Format code according to the existing code style (run npm run lint:check -- CHANGED_FILES and fix problems in changed code)
  • Create tests which fail without the change (if possible)
  • Make all tests (unit and integration) pass (npm run test:unit and npm run test:integration)
  • Extend the README / documentation and ensure is properly displayed (if necessary)
  • Provide JIRA issue id (if possible) or GitHub issue id in commit message

@sfc-gh-dprzybysz sfc-gh-dprzybysz requested a review from a team as a code owner October 6, 2023 14:36
@sfc-gh-dprzybysz sfc-gh-dprzybysz force-pushed the SNOW-933278-set-camelcase-eqeqeq-nosync-rules-for-eslint branch from 78f74cb to 1af8648 Compare October 6, 2023 14:47
.eslintrc.js Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

Merging #662 (6e081f1) into master (2e711fd) will decrease coverage by 0.36%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #662      +/-   ##
==========================================
- Coverage   87.90%   87.54%   -0.36%     
==========================================
  Files          60       60              
  Lines        5590     5590              
==========================================
- Hits         4914     4894      -20     
- Misses        676      696      +20     

see 6 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sfc-gh-pmotacki sfc-gh-pmotacki force-pushed the SNOW-933278-set-camelcase-eqeqeq-nosync-rules-for-eslint branch from 4504343 to 6e081f1 Compare October 23, 2023 08:12
@sfc-gh-pmotacki sfc-gh-pmotacki self-requested a review October 23, 2023 08:20
@sfc-gh-pmotacki sfc-gh-pmotacki merged commit 74442f2 into master Oct 23, 2023
6 of 7 checks passed
@sfc-gh-pmotacki sfc-gh-pmotacki deleted the SNOW-933278-set-camelcase-eqeqeq-nosync-rules-for-eslint branch October 23, 2023 08:45
@github-actions github-actions bot locked and limited conversation to collaborators Oct 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants