Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-334890: External browser SSO authentication with proxy #659

Merged
merged 3 commits into from
Oct 6, 2023
Merged

SNOW-334890: External browser SSO authentication with proxy #659

merged 3 commits into from
Oct 6, 2023

Conversation

sfc-gh-pmotacki
Copy link
Collaborator

Description

Please explain the changes you made here.

Checklist

  • Format code according to the existing code style (run npm run lint:check -- CHANGED_FILES and fix problems in changed code)
  • Create tests which fail without the change (if possible)
  • Make all tests (unit and integration) pass (npm run test:unit and npm run test:integration)
  • Extend the README / documentation and ensure is properly displayed (if necessary)
  • Provide JIRA issue id (if possible) or GitHub issue id in commit message

@sfc-gh-pmotacki sfc-gh-pmotacki force-pushed the SNOW-334890-extenral-browser-sso-with-proxy branch from afe40b3 to fa48855 Compare October 4, 2023 10:23
@sfc-gh-pmotacki sfc-gh-pmotacki marked this pull request as ready for review October 4, 2023 10:23
@sfc-gh-pmotacki sfc-gh-pmotacki requested a review from a team as a code owner October 4, 2023 10:23
sfc-gh-dprzybysz
sfc-gh-dprzybysz reviewed Oct 4, 2023
View reviewed changes
lib/services/sso_url_provider.js Outdated Show resolved Hide resolved
lib/services/sso_url_provider.js Outdated Show resolved Hide resolved
lib/services/sso_url_provider.js Outdated Show resolved Hide resolved
lib/authentication/auth_web.js Outdated Show resolved Hide resolved
lib/authentication/authentication.js Outdated Show resolved Hide resolved
lib/services/sso_url_provider.js Outdated Show resolved Hide resolved
lib/services/sso_url_provider.js Outdated Show resolved Hide resolved
lib/services/sso_url_provider.js Outdated Show resolved Hide resolved
lib/services/sso_url_provider.js Outdated Show resolved Hide resolved
test/unit/authentication/authentication_test.js Outdated Show resolved Hide resolved
@sfc-gh-pmotacki sfc-gh-pmotacki force-pushed the SNOW-334890-extenral-browser-sso-with-proxy branch 2 times, most recently from 2d5406c to 14f7a85 Compare October 4, 2023 16:07
sfc-gh-dprzybysz
sfc-gh-dprzybysz reviewed Oct 5, 2023
View reviewed changes
lib/authentication/auth_web.js Outdated Show resolved Hide resolved
lib/authentication/sso_url_provider.js Outdated Show resolved Hide resolved
lib/connection/connection.js Outdated Show resolved Hide resolved
lib/connection/connection.js Outdated Show resolved Hide resolved
lib/http/base.js Outdated Show resolved Hide resolved
lib/authentication/sso_url_provider.js Outdated Show resolved Hide resolved
@sfc-gh-pmotacki sfc-gh-pmotacki force-pushed the SNOW-334890-extenral-browser-sso-with-proxy branch from 14f7a85 to 1f99806 Compare October 5, 2023 12:54
sfc-gh-dprzybysz
sfc-gh-dprzybysz reviewed Oct 5, 2023
View reviewed changes
lib/http/base.js Show resolved Hide resolved
lib/http/base.js Outdated Show resolved Hide resolved
@sfc-gh-pmotacki sfc-gh-pmotacki force-pushed the SNOW-334890-extenral-browser-sso-with-proxy branch 6 times, most recently from e229d39 to a1b324c Compare October 6, 2023 06:13
@sfc-gh-pmotacki sfc-gh-pmotacki force-pushed the SNOW-334890-extenral-browser-sso-with-proxy branch 5 times, most recently from 796f1d0 to 7ba789b Compare October 6, 2023 12:31
@sfc-gh-pmotacki sfc-gh-pmotacki force-pushed the SNOW-334890-extenral-browser-sso-with-proxy branch from 7ba789b to 53eacf6 Compare October 6, 2023 13:06
@sfc-gh-pmotacki sfc-gh-pmotacki merged commit d01c4f4 into master Oct 6, 2023
5 checks passed
@sfc-gh-pmotacki sfc-gh-pmotacki deleted the SNOW-334890-extenral-browser-sso-with-proxy branch October 6, 2023 13:55
@github-actions github-actions bot locked and limited conversation to collaborators Oct 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-dprzybysz sfc-gh-dprzybysz sfc-gh-dprzybysz approved these changes

@sfc-gh-akolodziejczyk sfc-gh-akolodziejczyk Awaiting requested review from sfc-gh-akolodziejczyk

@sfc-gh-dheyman sfc-gh-dheyman Awaiting requested review from sfc-gh-dheyman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-pmotacki @sfc-gh-dprzybysz