Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-929946: Refactor connection with OCSP tests #658

Merged
merged 4 commits into from
Oct 4, 2023
Merged

SNOW-929946: Refactor connection with OCSP tests #658

merged 4 commits into from
Oct 4, 2023

Conversation

sfc-gh-dprzybysz
Copy link
Collaborator

Description

Please explain the changes you made here.

Checklist

  • Format code according to the existing code style (run npm run lint:check -- CHANGED_FILES and fix problems in changed code)
  • Create tests which fail without the change (if possible)
  • Make all tests (unit and integration) pass (npm run test:unit and npm run test:integration)
  • Extend the README / documentation and ensure is properly displayed (if necessary)
  • Provide JIRA issue id (if possible) or GitHub issue id in commit message

@sfc-gh-dprzybysz sfc-gh-dprzybysz requested a review from a team as a code owner October 3, 2023 13:19
@sfc-gh-dprzybysz sfc-gh-dprzybysz changed the title Snow 929946 refactor connection with ocsp tests SNOW-929946: Refactor connection with OCSP tests Oct 3, 2023
sfc-gh-pmotacki
sfc-gh-pmotacki approved these changes Oct 4, 2023
View reviewed changes
Copy link
Collaborator

@sfc-gh-pmotacki sfc-gh-pmotacki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add description to task SNOW-930797

@sfc-gh-dprzybysz sfc-gh-dprzybysz merged commit 40f370c into master Oct 4, 2023
5 checks passed
@sfc-gh-dprzybysz sfc-gh-dprzybysz deleted the SNOW-929946-refactor-connection-with-ocsp-tests branch October 4, 2023 08:02
@github-actions github-actions bot locked and limited conversation to collaborators Oct 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-pmotacki sfc-gh-pmotacki sfc-gh-pmotacki approved these changes

@sfc-gh-akolodziejczyk sfc-gh-akolodziejczyk sfc-gh-akolodziejczyk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-dprzybysz @sfc-gh-akolodziejczyk @sfc-gh-pmotacki