Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-898291: Add asn1.js to peerDependency and update @techteamer/ocsp #654

Merged
merged 3 commits into from
Sep 29, 2023
Merged

SNOW-898291: Add asn1.js to peerDependency and update @techteamer/ocsp #654

merged 3 commits into from
Sep 29, 2023

Conversation

sfc-gh-ext-simba-lf
Copy link
Collaborator

Description

Regarding issue 622

Some versions of package managers do not install the asn1.js package resulting in an error so the PR adds asn1.js as a peer dependency. The @techteamer/ocsp package which uses asn1.js as a direct dependency is also updated

Checklist

  • Format code according to the existing code style (run npm run lint:check -- CHANGED_FILES and fix problems in changed code)
  • Create tests which fail without the change (if possible)
  • Make all tests (unit and integration) pass (npm run test:unit and npm run test:integration)
  • Extend the README / documentation and ensure is properly displayed (if necessary)
  • Provide JIRA issue id (if possible) or GitHub issue id in commit message

@sfc-gh-ext-simba-lf sfc-gh-ext-simba-lf marked this pull request as ready for review September 28, 2023 19:30
@sfc-gh-ext-simba-lf sfc-gh-ext-simba-lf requested a review from a team as a code owner September 28, 2023 19:30
@sfc-gh-dszmolka sfc-gh-dszmolka mentioned this pull request Sep 29, 2023
Closed
@sfc-gh-ext-simba-lf sfc-gh-ext-simba-lf merged commit 2645782 into master Sep 29, 2023
5 checks passed
@sfc-gh-ext-simba-lf sfc-gh-ext-simba-lf deleted the SNOW-898291-asn1-peer-dependency branch September 29, 2023 17:08
@github-actions github-actions bot locked and limited conversation to collaborators Sep 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-dprzybysz sfc-gh-dprzybysz sfc-gh-dprzybysz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-ext-simba-lf @sfc-gh-dprzybysz