Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-896752 - Add node20 on Ubuntu to github action tests #651

Merged
merged 4 commits into from
Oct 2, 2023
Merged

SNOW-896752 - Add node20 on Ubuntu to github action tests #651

merged 4 commits into from
Oct 2, 2023

Conversation

sfc-gh-pmotacki
Copy link
Collaborator

Description

Please explain the changes you made here.

Checklist

  • Format code according to the existing code style (run npm run lint:check -- CHANGED_FILES and fix problems in changed code)
  • Create tests which fail without the change (if possible)
  • Make all tests (unit and integration) pass (npm run test:unit and npm run test:integration)
  • Extend the README / documentation and ensure is properly displayed (if necessary)
  • Provide JIRA issue id (if possible) or GitHub issue id in commit message

@sfc-gh-pmotacki sfc-gh-pmotacki force-pushed the SNOW-896752-node20 branch 6 times, most recently from b9a172f to 3e9a41a Compare September 27, 2023 13:37
@sfc-gh-pmotacki sfc-gh-pmotacki marked this pull request as ready for review September 28, 2023 08:13
@sfc-gh-pmotacki sfc-gh-pmotacki requested a review from a team as a code owner September 28, 2023 08:13
sfc-gh-dprzybysz
sfc-gh-dprzybysz reviewed Sep 28, 2023
View reviewed changes
.github/workflows/build-test.yml Show resolved Hide resolved
.github/workflows/build-test.yml Outdated Show resolved Hide resolved
ci/test_ubuntu.sh Show resolved Hide resolved
@sfc-gh-pmotacki sfc-gh-pmotacki force-pushed the SNOW-896752-node20 branch 2 times, most recently from d87c35c to ad1fc9c Compare September 28, 2023 09:55
@sfc-gh-pmotacki sfc-gh-pmotacki force-pushed the SNOW-896752-node20 branch 5 times, most recently from 3eeb4b9 to 3f7ae45 Compare September 29, 2023 12:16
@sfc-gh-pmotacki sfc-gh-pmotacki merged commit 39abad3 into master Oct 2, 2023
5 checks passed
@sfc-gh-pmotacki sfc-gh-pmotacki deleted the SNOW-896752-node20 branch October 2, 2023 08:29
@github-actions github-actions bot locked and limited conversation to collaborators Oct 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-pbulawa sfc-gh-pbulawa sfc-gh-pbulawa left review comments

@sfc-gh-dprzybysz sfc-gh-dprzybysz sfc-gh-dprzybysz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-pmotacki @sfc-gh-dprzybysz @sfc-gh-pbulawa