Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-856233 Easy logging #642

Merged
merged 1 commit into from
Oct 10, 2023
Merged

SNOW-856233 Easy logging #642

merged 1 commit into from
Oct 10, 2023

Conversation

sfc-gh-knozderko
Copy link
Collaborator

@sfc-gh-knozderko sfc-gh-knozderko commented Sep 20, 2023 •
edited
Loading

Description

SNOW-856233 Easy logging

Checklist

  • Format code according to the existing code style (run npm run lint:check -- CHANGED_FILES and fix problems in changed code)
  • Create tests which fail without the change (if possible)
  • Make all tests (unit and integration) pass (npm run test:unit and npm run test:integration)
  • Extend the README / documentation and ensure is properly displayed (if necessary)
  • Provide JIRA issue id (if possible) or GitHub issue id in commit message

@sfc-gh-knozderko sfc-gh-knozderko requested a review from a team as a code owner September 20, 2023 14:42
sfc-gh-dprzybysz
sfc-gh-dprzybysz reviewed Sep 21, 2023
View reviewed changes
lib/configuration/configuration_parser.js Outdated Show resolved Hide resolved
lib/configuration/configuration_parser.js Outdated Show resolved Hide resolved
lib/configuration/configuration_parser.js Outdated Show resolved Hide resolved
lib/configuration/configuration_parser.js Outdated Show resolved Hide resolved
lib/configuration/configuration_parser.js Outdated Show resolved Hide resolved
test/unit/configuration/configuration_parser_test.js Outdated Show resolved Hide resolved
test/unit/configuration/configuration_parser_test.js Outdated Show resolved Hide resolved
test/unit/configuration/configuration_parser_test.js Outdated Show resolved Hide resolved
test/unit/configuration/configuration_parser_test.js Outdated Show resolved Hide resolved
test/unit/configuration/configuration_parser_test.js Outdated Show resolved Hide resolved
@sfc-gh-knozderko sfc-gh-knozderko force-pushed the SNOW-856233_easy_logging_parser branch from 4e81909 to fb051fc Compare October 5, 2023 13:35
@sfc-gh-knozderko sfc-gh-knozderko changed the title SNOW-856233 easy logging parser SNOW-856233 Easy logging Oct 6, 2023
sfc-gh-pmotacki
sfc-gh-pmotacki reviewed Oct 9, 2023
View reviewed changes
lib/core.js Outdated Show resolved Hide resolved
@sfc-gh-knozderko sfc-gh-knozderko force-pushed the SNOW-856233_easy_logging_parser branch from 6144e84 to fb4f4a0 Compare October 10, 2023 15:05
@sfc-gh-knozderko sfc-gh-knozderko merged commit bd44c97 into master Oct 10, 2023
5 checks passed
@sfc-gh-knozderko sfc-gh-knozderko deleted the SNOW-856233_easy_logging_parser branch October 10, 2023 16:01
@github-actions github-actions bot locked and limited conversation to collaborators Oct 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-dprzybysz sfc-gh-dprzybysz sfc-gh-dprzybysz left review comments

@sfc-gh-pmotacki sfc-gh-pmotacki sfc-gh-pmotacki approved these changes

@sfc-gh-akolodziejczyk sfc-gh-akolodziejczyk sfc-gh-akolodziejczyk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sfc-gh-knozderko @sfc-gh-akolodziejczyk @sfc-gh-dprzybysz @sfc-gh-pmotacki