Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-743920: Cache all types of HTTPS agent #641

Merged
merged 3 commits into from
Sep 29, 2023
Merged

SNOW-743920: Cache all types of HTTPS agent #641

merged 3 commits into from
Sep 29, 2023

Conversation

sfc-gh-pmotacki
Copy link
Collaborator

Description

Please explain the changes you made here.

Checklist

  • Format code according to the existing code style (run npm run lint:check -- CHANGED_FILES and fix problems in changed code)
  • Create tests which fail without the change (if possible)
  • Make all tests (unit and integration) pass (npm run test:unit and npm run test:integration)
  • Extend the README / documentation and ensure is properly displayed (if necessary)
  • Provide JIRA issue id (if possible) or GitHub issue id in commit message

@sfc-gh-pmotacki sfc-gh-pmotacki force-pushed the SNOW-743920-cache-https-agent2 branch 12 times, most recently from f5bc634 to b4d8b4b Compare September 22, 2023 07:22
@sfc-gh-pmotacki sfc-gh-pmotacki marked this pull request as ready for review September 22, 2023 07:28
@sfc-gh-pmotacki sfc-gh-pmotacki requested a review from a team as a code owner September 22, 2023 07:28
sfc-gh-dprzybysz
sfc-gh-dprzybysz reviewed Sep 22, 2023
View reviewed changes
lib/global_config.js Outdated Show resolved Hide resolved
lib/http/base.js Outdated Show resolved Hide resolved
lib/http/node.js Outdated Show resolved Hide resolved
lib/http/node.js Outdated Show resolved Hide resolved
test/integration/ocsp_mock/testConnectionOcspMock.js Outdated Show resolved Hide resolved
test/integration/testLargeResultSet.js Show resolved Hide resolved
test/integration/testManualConnection.js Outdated Show resolved Hide resolved
test/integration/testManualConnection.js Outdated Show resolved Hide resolved
test/integration/testManualConnection.js Outdated Show resolved Hide resolved
test/integration/testManualConnection.js Outdated Show resolved Hide resolved
@sfc-gh-pmotacki sfc-gh-pmotacki force-pushed the SNOW-743920-cache-https-agent2 branch 2 times, most recently from f805d23 to d638ef7 Compare September 22, 2023 12:50
sfc-gh-dprzybysz
sfc-gh-dprzybysz approved these changes Sep 22, 2023
View reviewed changes
lib/core.js Outdated Show resolved Hide resolved
test/integration/testManualConnection.js Outdated Show resolved Hide resolved
@sfc-gh-pmotacki sfc-gh-pmotacki force-pushed the SNOW-743920-cache-https-agent2 branch from d638ef7 to 53a57b3 Compare September 22, 2023 13:58
sfc-gh-dprzybysz
sfc-gh-dprzybysz approved these changes Sep 25, 2023
View reviewed changes
lib/global_config.js Outdated Show resolved Hide resolved
@sfc-gh-pmotacki sfc-gh-pmotacki force-pushed the SNOW-743920-cache-https-agent2 branch 2 times, most recently from c489d58 to f3a17cc Compare September 29, 2023 07:23
sfc-gh-dprzybysz
sfc-gh-dprzybysz reviewed Sep 29, 2023
View reviewed changes
lib/http/node.js Outdated Show resolved Hide resolved
@sfc-gh-pmotacki sfc-gh-pmotacki force-pushed the SNOW-743920-cache-https-agent2 branch from f3a17cc to 61c3db5 Compare September 29, 2023 11:22
@sfc-gh-pmotacki sfc-gh-pmotacki force-pushed the SNOW-743920-cache-https-agent2 branch from 61c3db5 to 4e19da2 Compare September 29, 2023 11:23
@sfc-gh-pmotacki sfc-gh-pmotacki merged commit 35869a8 into master Sep 29, 2023
5 checks passed
@sfc-gh-pmotacki sfc-gh-pmotacki deleted the SNOW-743920-cache-https-agent2 branch September 29, 2023 12:45
@github-actions github-actions bot locked and limited conversation to collaborators Sep 29, 2023
@sfc-gh-pmotacki sfc-gh-pmotacki changed the title SNOW-734920: Cache all types of HTTPS agent SNOW-743920: Cache all types of HTTPS agent Sep 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-dprzybysz sfc-gh-dprzybysz sfc-gh-dprzybysz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-pmotacki @sfc-gh-dprzybysz