Result calling issue #640
Closed
Result calling issue #640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-ext-simba-jy
requested review from
sfc-gh-dprzybysz and
sfc-gh-pmotacki
test/unit/result_test.js
Outdated
| complete: function (err, stmt) | ||
| { | ||
| testUtil.checkError(err); | ||
| var stream = stmt.streamRows(); |
There was a problem hiding this comment.
you are reading from stream here - so you need to set streamResult to true as described in https://docs.snowflake.com/en/developer-guide/node-js/nodejs-driver-consume#streaming-results
There was a problem hiding this comment.
I set this because this is a testing code. Although I set streamResult:true option, the driver still called result.js twice. I remove the stream and just added simple check.
|
This issue is solved, so close this PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a PR to investigate the issue that the result.js called twice per execution.
How to Test: Run SNOWFLAKE_TEST_USER="" SNOWFLAKE_TEST_PASSWORD="!" SNOWFLAKE_TEST_ACCOUNT="" SNOWFLAKE_TEST_WAREHOUSE="" SNOWFLAKE_TEST_DATABASE="" SNOWFLAKE_TEST_SCHEMA="" npm test
Here is my trace level logs: snowflake.log
ChecklistC:\Users\JYun\workspaces\snowflake-connector-nodejs\testing.js
npm run lint:check -- CHANGED_FILESand fix problems in changed code)npm run test:unitandnpm run test:integration)