-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SNOW-728803: Do not replace sqlText if it is specified by the user #639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nector-nodejs into SNOW-728803-request-id-sqlText
…nector-nodejs into SNOW-728803-request-id-sqlText
Added test for special case when resubmitting a request:
If the sqlText is replaced, the response from |
…nector-nodejs into SNOW-728803-request-id-sqlText
…nector-nodejs into SNOW-728803-request-id-sqlText
…nector-nodejs into SNOW-728803-request-id-sqlText
sfc-gh-dprzybysz
approved these changes
Oct 6, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Regarding issue 137
The PR fixes a special case for submitting queries with requestId where:
With the PR, the sqlText will not be replaced if the user specifies a sqlText
So even if the original request fails, the connector will still execute the sqlText specified by the user
Checklist
npm run lint:check -- CHANGED_FILES
and fix problems in changed code)npm run test:unit
andnpm run test:integration
)