Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-811103 script to testing json parsers #638

Merged
merged 1 commit into from
Sep 20, 2023
Merged

SNOW-811103 script to testing json parsers #638

merged 1 commit into from
Sep 20, 2023

Conversation

sfc-gh-pmotacki
Copy link
Collaborator

@sfc-gh-pmotacki sfc-gh-pmotacki commented Sep 15, 2023 •
edited
Loading

Description

Please explain the changes you made here.

Checklist

  • Format code according to the existing code style (run npm run lint:check -- CHANGED_FILES and fix problems in changed code)
  • Create tests which fail without the change (if possible)
  • Make all tests (unit and integration) pass (npm run test:unit and npm run test:integration)
  • Extend the README / documentation and ensure is properly displayed (if necessary)
  • Provide JIRA issue id (if possible) or GitHub issue id in commit message

@sfc-gh-pmotacki sfc-gh-pmotacki changed the title Snow 811103 test parser script Snow 811103 script to testing json parsers Sep 15, 2023
@sfc-gh-pmotacki sfc-gh-pmotacki changed the title Snow 811103 script to testing json parsers SNOW-811103 script to testing json parsers Sep 15, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Sep 15, 2023
@sfc-gh-pmotacki sfc-gh-pmotacki marked this pull request as ready for review September 15, 2023 10:39
@sfc-gh-pmotacki sfc-gh-pmotacki requested a review from a team as a code owner September 15, 2023 10:39
@sfc-gh-pmotacki sfc-gh-pmotacki force-pushed the SNOW-811103-testParserScript branch 3 times, most recently from df550e1 to 26edb47 Compare September 15, 2023 10:58
sfc-gh-dprzybysz
sfc-gh-dprzybysz reviewed Sep 15, 2023
View reviewed changes
lib/global_config.js Outdated Show resolved Hide resolved
test/integration/testLargeResultSet.js Outdated Show resolved Hide resolved
test/integration/testLargeResultSet.js Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
samples/package.json Outdated Show resolved Hide resolved
samples/jsonParserComparison.js Outdated Show resolved Hide resolved
samples/jsonParserComparison.js Outdated Show resolved Hide resolved
samples/jsonParserComparison.js Show resolved Hide resolved
samples/jsonParserComparison.js Outdated Show resolved Hide resolved
samples/jsonParserComparison.js Outdated Show resolved Hide resolved
@sfc-gh-pmotacki sfc-gh-pmotacki force-pushed the SNOW-811103-testParserScript branch 2 times, most recently from c53f068 to 65d8a63 Compare September 15, 2023 14:20
sfc-gh-dprzybysz
sfc-gh-dprzybysz reviewed Sep 18, 2023
View reviewed changes
samples/package.json Outdated Show resolved Hide resolved
samples/package.json Outdated Show resolved Hide resolved
sfc-gh-dprzybysz
sfc-gh-dprzybysz reviewed Sep 18, 2023
View reviewed changes
samples/jsonParserComparison.js Outdated Show resolved Hide resolved
samples/README.md Show resolved Hide resolved
@sfc-gh-pmotacki sfc-gh-pmotacki force-pushed the SNOW-811103-testParserScript branch from 65d8a63 to 2c5110d Compare September 18, 2023 06:47
@sfc-gh-pmotacki sfc-gh-pmotacki force-pushed the SNOW-811103-testParserScript branch from 2c5110d to c8504a3 Compare September 19, 2023 10:17
@sfc-gh-pmotacki sfc-gh-pmotacki force-pushed the SNOW-811103-testParserScript branch from c8504a3 to 3bdd20b Compare September 19, 2023 14:40
@sfc-gh-pmotacki sfc-gh-pmotacki merged commit 48d2049 into master Sep 20, 2023
@sfc-gh-pmotacki sfc-gh-pmotacki deleted the SNOW-811103-testParserScript branch September 20, 2023 06:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-dprzybysz sfc-gh-dprzybysz sfc-gh-dprzybysz approved these changes

@sfc-gh-dheyman sfc-gh-dheyman Awaiting requested review from sfc-gh-dheyman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-pmotacki @sfc-gh-dprzybysz