Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-811103: Set new Function as default json parser #635

Merged
merged 1 commit into from
Sep 19, 2023
Merged

SNOW-811103: Set new Function as default json parser #635

merged 1 commit into from
Sep 19, 2023

Conversation

sfc-gh-dprzybysz
Copy link
Collaborator

Description

Set new Function as default json parser

Checklist

  • Format code according to the existing code style (run npm run lint:check -- CHANGED_FILES and fix problems in changed code)
  • Create tests which fail without the change (if possible)
  • Make all tests (unit and integration) pass (npm run test:unit and npm run test:integration)
  • Extend the README / documentation and ensure is properly displayed (if necessary)
  • Provide JIRA issue id (if possible) or GitHub issue id in commit message

@sfc-gh-dprzybysz sfc-gh-dprzybysz marked this pull request as ready for review September 14, 2023 06:18
@sfc-gh-dprzybysz sfc-gh-dprzybysz requested a review from a team as a code owner September 14, 2023 06:18
sfc-gh-pmotacki
sfc-gh-pmotacki approved these changes Sep 14, 2023
View reviewed changes
Copy link
Collaborator

@sfc-gh-pmotacki sfc-gh-pmotacki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sfc-gh-pmotacki
sfc-gh-pmotacki approved these changes Sep 15, 2023
View reviewed changes
Copy link
Collaborator

@sfc-gh-pmotacki sfc-gh-pmotacki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfc-gh-dprzybysz sfc-gh-dprzybysz force-pushed the SNOW-811103-set-new-function-as-default-json-parser branch from d669140 to 55c21f9 Compare September 19, 2023 07:57
@sfc-gh-dprzybysz sfc-gh-dprzybysz merged commit 3cd1da7 into master Sep 19, 2023
5 checks passed
@sfc-gh-dprzybysz sfc-gh-dprzybysz deleted the SNOW-811103-set-new-function-as-default-json-parser branch September 19, 2023 09:21
@github-actions github-actions bot locked and limited conversation to collaborators Sep 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-pmotacki sfc-gh-pmotacki sfc-gh-pmotacki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-dprzybysz @sfc-gh-pmotacki