Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-871416: [HTAP] Query Context Caching for Node #631

Merged
merged 36 commits into from
Sep 22, 2023
Merged

SNOW-871416: [HTAP] Query Context Caching for Node #631

merged 36 commits into from
Sep 22, 2023

Conversation

sfc-gh-ext-simba-jy
Copy link
Collaborator

@sfc-gh-ext-simba-jy sfc-gh-ext-simba-jy commented Sep 6, 2023 •
edited
Loading

Description

Please explain the changes you made here.

Checklist

  • Format code according to the existing code style (run npm run lint:check -- CHANGED_FILES and fix problems in changed code)
  • Create tests which fail without the change (if possible)
  • Make all tests (unit and integration) pass (npm run test:unit and npm run test:integration)
  • Extend the README / documentation and ensure is properly displayed (if necessary)
  • Provide JIRA issue id (if possible) or GitHub issue id in commit message

ghost
ghost reviewed Sep 7, 2023
View reviewed changes
lib/errors.js Outdated Show resolved Hide resolved
@sfc-gh-ext-simba-jy sfc-gh-ext-simba-jy requested a review from a user September 8, 2023 15:07
ghost
ghost approved these changes Sep 8, 2023
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except some extra spaces added to empty line.

@sfc-gh-ext-simba-jy sfc-gh-ext-simba-jy marked this pull request as ready for review September 8, 2023 19:24
@sfc-gh-ext-simba-jy sfc-gh-ext-simba-jy requested a review from a team as a code owner September 8, 2023 19:24
@sfc-gh-ext-simba-jy sfc-gh-ext-simba-jy added the status-pr_pending_merge A PR is made and is under review label Sep 11, 2023
sfc-gh-dprzybysz
sfc-gh-dprzybysz reviewed Sep 22, 2023
View reviewed changes
lib/connection/connection_config.js Show resolved Hide resolved
lib/connection/statement.js Show resolved Hide resolved
lib/queryContextCache.js Outdated Show resolved Hide resolved
lib/services/sf.js Show resolved Hide resolved
test/integration/testHTAP.js Outdated Show resolved Hide resolved
test/integration/testHTAP.js Outdated Show resolved Hide resolved
test/integration/testHTAP.js Show resolved Hide resolved
test/integration/testHTAP.js Outdated Show resolved Hide resolved
test/unit/query_context_cache_test.js Outdated Show resolved Hide resolved
test/unit/query_context_cache_test.js Show resolved Hide resolved
sfc-gh-pmotacki
sfc-gh-pmotacki reviewed Sep 22, 2023
View reviewed changes
lib/queryContextCache.js Show resolved Hide resolved
lib/queryContextCache.js Outdated Show resolved Hide resolved
@sfc-gh-ext-simba-jy sfc-gh-ext-simba-jy merged commit 6de55e6 into master Sep 22, 2023
5 checks passed
@sfc-gh-ext-simba-jy sfc-gh-ext-simba-jy deleted the contextcache branch September 22, 2023 08:47
@github-actions github-actions bot locked and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-pmotacki sfc-gh-pmotacki sfc-gh-pmotacki approved these changes

@sfc-gh-dprzybysz sfc-gh-dprzybysz sfc-gh-dprzybysz approved these changes

@sfc-gh-ext-simba-lf sfc-gh-ext-simba-lf Awaiting requested review from sfc-gh-ext-simba-lf

@sfc-gh-igarish sfc-gh-igarish Awaiting requested review from sfc-gh-igarish

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sfc-gh-ext-simba-jy @sfc-gh-ext-simba-lf @sfc-gh-dprzybysz @sfc-gh-pmotacki