Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-871839: Fix snyk permissions #583

Merged
merged 3 commits into from
Sep 22, 2023
Merged

SNOW-871839: Fix snyk permissions #583

merged 3 commits into from
Sep 22, 2023

Conversation

sfc-gh-pbulawa
Copy link
Collaborator

Description

Fix snyk permissions.

Checklist

  • Format code according to the existing code style (run npm run lint:check -- CHANGED_FILES and fix problems in changed code)
  • Create tests which fail without the change (if possible)
  • Make all tests (unit and integration) pass (npm run test:unit and npm run test:integration)
  • Extend the README / documentation and ensure is properly displayed (if necessary)
  • Provide JIRA issue id (if possible) or GitHub issue id in commit message

@sfc-gh-pbulawa sfc-gh-pbulawa requested a review from a team as a code owner July 19, 2023 13:41
@codecov
Copy link

codecov bot commented Jul 19, 2023 •
edited
Loading

Codecov Report

Merging #583 (10fd96e) into master (4cacb2c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #583   +/-   ##
=======================================
  Coverage   84.51%   84.51%           
=======================================
  Files          54       54           
  Lines        5135     5135           
=======================================
  Hits         4340     4340           
  Misses        795      795

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sfc-gh-pbulawa sfc-gh-pbulawa force-pushed the SNOW-871839_fix_snyk_permissions branch from 10fd96e to 4e75ef8 Compare August 23, 2023 12:41
@github-actions github-actions bot locked and limited conversation to collaborators Aug 23, 2023
sfc-gh-igarish
sfc-gh-igarish approved these changes Aug 23, 2023
View reviewed changes
Copy link
Collaborator

@sfc-gh-igarish sfc-gh-igarish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfc-gh-pbulawa sfc-gh-pbulawa merged commit 5dcb8fc into master Sep 22, 2023
5 checks passed
@sfc-gh-pbulawa sfc-gh-pbulawa deleted the SNOW-871839_fix_snyk_permissions branch September 22, 2023 11:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-jfan sfc-gh-jfan sfc-gh-jfan left review comments

@sfc-gh-dprzybysz sfc-gh-dprzybysz sfc-gh-dprzybysz approved these changes

@sfc-gh-igarish sfc-gh-igarish sfc-gh-igarish approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sfc-gh-pbulawa @sfc-gh-jfan @sfc-gh-igarish @sfc-gh-dprzybysz