Skip to content

Commit

Permalink
SNOW-1284306 unused debug dependency causes conflict in certain fra…
Browse files Browse the repository at this point in the history
…meworks, remove unused deps (#824)

SNOW-1284306 apparently in `express.js` when there's a newer (v4) `debug` in use, starting up the server which depends on `snowflake-sdk` throws an error `exports.useColors is not a function` which comes from `debug` v3 which is a direct dependency of the Snowflake Node.js driver.

Possible approaches would to to upgrade the `debug` package we depend on, or just remove it altogether because it looks like since PR 689, we don't even use the following packages anymore:
```
snowflake-connector-nodejs# depcheck .
Unused dependencies
* agent-base
* debug
* extend
```

* `debug` - [removed in PR 689](https://github.com/snowflakedb/snowflake-connector-nodejs/pull/689/files#diff-82db7d4c9169d26dd65b0e50a6329f63aabc7e5c1eff28e57b606eefbd3dc498L16)
* `agent-base` - [removed in PR 689](https://github.com/snowflakedb/snowflake-connector-nodejs/pull/689/files#diff-82db7d4c9169d26dd65b0e50a6329f63aabc7e5c1eff28e57b606eefbd3dc498L14)
* `extend` - [removed in PR 689](https://github.com/snowflakedb/snowflake-connector-nodejs/pull/689/files#diff-82db7d4c9169d26dd65b0e50a6329f63aabc7e5c1eff28e57b606eefbd3dc498L12)
  • Loading branch information
sfc-gh-dszmolka authored Apr 9, 2024
1 parent ec00a1d commit bffaf4c
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
"@azure/storage-blob": "^12.11.0",
"@google-cloud/storage": "^7.7.0",
"@techteamer/ocsp": "1.0.1",
"agent-base": "^6.0.2",
"asn1.js-rfc2560": "^5.0.0",
"asn1.js-rfc5280": "^3.0.0",
"axios": "^1.6.8",
Expand All @@ -17,9 +16,7 @@
"binascii": "0.0.2",
"bn.js": "^5.2.1",
"browser-request": "^0.3.3",
"debug": "^3.2.6",
"expand-tilde": "^2.0.2",
"extend": "^3.0.2",
"fast-xml-parser": "^4.2.5",
"fastest-levenshtein": "^1.0.16",
"generic-pool": "^3.8.2",
Expand Down

0 comments on commit bffaf4c

Please sign in to comment.