Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1226614: Add parameter to disable SAML url check #983

Merged
merged 4 commits into from
Jul 4, 2024

Conversation

sfc-gh-ext-simba-lf
Copy link
Collaborator

Description

Add parameter to disable SAML url check

Checklist

  • Code compiles correctly
  • Code is formatted according to Coding Conventions
  • Created tests which fail without the change (if possible)
  • All tests passing (dotnet test)
  • Extended the README / documentation, if necessary
  • Provide JIRA issue id (if possible) or GitHub issue id in PR name

Copy link

codecov bot commented Jun 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.63%. Comparing base (1465bda) to head (adbe2b0).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #983      +/-   ##
==========================================
+ Coverage   85.43%   85.63%   +0.19%     
==========================================
  Files         106      106              
  Lines       10761    10773      +12     
  Branches     1029     1031       +2     
==========================================
+ Hits         9194     9225      +31     
+ Misses       1318     1299      -19     
  Partials      249      249              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfc-gh-ext-simba-lf sfc-gh-ext-simba-lf marked this pull request as ready for review June 25, 2024 21:21
@sfc-gh-ext-simba-lf sfc-gh-ext-simba-lf requested a review from a team as a code owner June 25, 2024 21:21
@sfc-gh-ext-simba-lf sfc-gh-ext-simba-lf merged commit cd2078d into master Jul 4, 2024
53 checks passed
@sfc-gh-ext-simba-lf sfc-gh-ext-simba-lf deleted the SNOW-1226614-Disable-SAML-Url-Check branch July 4, 2024 19:24
@github-actions github-actions bot locked and limited conversation to collaborators Jul 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants