Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "SNOW-1473274 bump nunit to 4.1.0 (#971)" #973

Merged
merged 1 commit into from
Jun 11, 2024
Merged

Revert "SNOW-1473274 bump nunit to 4.1.0 (#971)" #973

merged 1 commit into from
Jun 11, 2024

Conversation

sfc-gh-knozderko
Copy link
Collaborator

This reverts commit 0e7a4ad.

Description

Reverting switching to newer NUnit since it does not support .netstandard.

Checklist

  • Code compiles correctly
  • Code is formatted according to Coding Conventions
  • Created tests which fail without the change (if possible)
  • All tests passing (dotnet test)
  • Extended the README / documentation, if necessary
  • Provide JIRA issue id (if possible) or GitHub issue id in PR name

@sfc-gh-knozderko sfc-gh-knozderko requested a review from a team as a code owner June 11, 2024 14:36
@sfc-gh-knozderko sfc-gh-knozderko merged commit 39dcb03 into master Jun 11, 2024
31 of 33 checks passed
@sfc-gh-knozderko sfc-gh-knozderko deleted the SNOW-1473274_revert_upgrading_nunit branch June 11, 2024 14:53
@github-actions github-actions bot locked and limited conversation to collaborators Jun 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-dstempniak sfc-gh-dstempniak sfc-gh-dstempniak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-knozderko @sfc-gh-dstempniak