Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync connection pool with master #965

Merge branch 'master' into pool/SNOW-860872-connection-pool

4c8d516
Select commit
Loading
Failed to load commit list.
Merged

Sync connection pool with master #965

Merge branch 'master' into pool/SNOW-860872-connection-pool
4c8d516
Select commit
Loading
Failed to load commit list.
GitGuardian / GitGuardian Security Checks completed Jun 7, 2024 in 6s

2 secrets uncovered!

2 secrets were uncovered from the scan of 27 commits in your pull request. ❌

Please have a look to GitGuardian findings and remediate in order to secure your code.

Details

🔎 Detected hardcoded secrets in your pull request

  • Pull request #955: pool/SNOW-860872-connection-pool 👉 master
GitGuardian id GitGuardian status Secret Commit Filename
9511947 Triggered ODBC Connection String 5a3c451 Snowflake.Data.Tests/UnitTests/SFOktaTest.cs View secret
9511947 Triggered ODBC Connection String 5a3c451 Snowflake.Data.Tests/UnitTests/SFOktaTest.cs View secret

🛠 Guidelines to remediate hardcoded secrets

The above secret(s) have been detected in your PR. Please take an appropriate action for each secret:

  • If it’s a true positive, remove the secret from source code, revoke it and migrate to a secure way of storing and accessing secrets (see http://go/secrets-and-code). Once that’s done, go to the incidents page linked in the “GitGuardian id” column (log in using SnowBiz Okta) and resolve the incident.
  • If it’s a false positive, go to the incidents page linked in the “GitGuardian id” column (log in using SnowBiz Okta) and ignore the incident.
  • If you didn't add this secret - and only then - you may ignore this check as it's non-blocking. If you did add the secret and you ignore this check, you'll be assigned a "Security Finding" ticket in Jira in a few days.

Note:

  • A secret is considered leaked from the moment it touches GitHub. Rewriting git history by force pushing or other means is not necessary and doesn’t change the fact that the secret has to be revoked.
  • This check has a “Skip: false positive” button. Don’t use it. It will mark all detected secrets as false positives but only in the context of this specific run - it won’t remember this action in subsequent check runs.

If you encounter any problems you can reach out to us on Slack: #gitguardian-secret-scanning-help


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.