Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1337069 connection pool doc fix #958

Conversation

sfc-gh-knozderko
Copy link
Collaborator

Description

SNOW-1337069 Fix note about special signs in connection string

Checklist

  • Code compiles correctly
  • Code is formatted according to Coding Conventions
  • Created tests which fail without the change (if possible)
  • All tests passing (dotnet test)
  • Extended the README / documentation, if necessary
  • Provide JIRA issue id (if possible) or GitHub issue id in PR name

@sfc-gh-knozderko sfc-gh-knozderko requested a review from a team as a code owner May 29, 2024 13:18
Copy link

codecov bot commented May 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.31%. Comparing base (921b9df) to head (c7f4575).

Additional details and impacted files
@@                         Coverage Diff                          @@
##           pool/SNOW-860872-connection-pool     #958      +/-   ##
====================================================================
- Coverage                             85.56%   85.31%   -0.25%     
====================================================================
  Files                                   106      106              
  Lines                                 10742    10742              
  Branches                               1027     1027              
====================================================================
- Hits                                   9191     9165      -26     
- Misses                                 1302     1329      +27     
+ Partials                                249      248       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfc-gh-knozderko sfc-gh-knozderko merged commit 815f708 into pool/SNOW-860872-connection-pool May 29, 2024
22 of 32 checks passed
@sfc-gh-knozderko sfc-gh-knozderko deleted the SNOW-1337069_-connection-pool_doc_fix branch May 29, 2024 15:11
@github-actions github-actions bot locked and limited conversation to collaborators May 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants