Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pool flaky test #950

Merged
merged 1 commit into from
May 17, 2024

Conversation

sfc-gh-knozderko
Copy link
Collaborator

Description

Fix pool flaky test.

Checklist

  • Code compiles correctly
  • Code is formatted according to Coding Conventions
  • Created tests which fail without the change (if possible)
  • All tests passing (dotnet test)
  • Extended the README / documentation, if necessary
  • Provide JIRA issue id (if possible) or GitHub issue id in PR name

@sfc-gh-knozderko sfc-gh-knozderko requested a review from a team as a code owner May 17, 2024 09:08
Copy link

codecov bot commented May 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.38%. Comparing base (b2b0ddc) to head (ae8b9de).

Additional details and impacted files
@@                         Coverage Diff                          @@
##           pool/SNOW-860872-connection-pool     #950      +/-   ##
====================================================================
+ Coverage                             85.32%   85.38%   +0.06%     
====================================================================
  Files                                   106      106              
  Lines                                 10668    10668              
  Branches                               1024     1024              
====================================================================
+ Hits                                   9102     9109       +7     
+ Misses                                 1319     1312       -7     
  Partials                                247      247              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfc-gh-knozderko sfc-gh-knozderko merged commit 967528d into pool/SNOW-860872-connection-pool May 17, 2024
21 of 23 checks passed
@sfc-gh-knozderko sfc-gh-knozderko deleted the pool/flaky_test branch May 17, 2024 10:54
@github-actions github-actions bot locked and limited conversation to collaborators May 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants