Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1360070 upgrade docker container to Ubuntu 20.04 dotnet 8 #940

Merged
merged 3 commits into from
May 15, 2024
Merged

SNOW-1360070 upgrade docker container to Ubuntu 20.04 dotnet 8 #940

merged 3 commits into from
May 15, 2024

Conversation

sfc-gh-erojaslizano
Copy link
Contributor

@sfc-gh-erojaslizano sfc-gh-erojaslizano commented May 3, 2024 •
edited
Loading

Description

  • Upgrade docker file to build cent os 8 with dotnet 8 framework
  • Update jenkins file to reference new container
  • Update .csproj to compile with dotnet 8

Checklist

  • Code compiles correctly
  • Code is formatted according to Coding Conventions
  • Created tests which fail without the change (if possible)
  • All tests passing (dotnet test)
  • Extended the README / documentation, if necessary
  • Provide JIRA issue id (if possible) or GitHub issue id in PR name

@sfc-gh-erojaslizano sfc-gh-erojaslizano force-pushed the update-to-dotnet-8 branch 2 times, most recently from 4ec5ab8 to 1c685d3 Compare May 3, 2024 20:43
@sfc-gh-erojaslizano sfc-gh-erojaslizano changed the title SNOW-1360070 upgrade docker container to centOS8 dotnet 8 SNOW-1360070 upgrade docker container to Ubuntu 20.04 dotnet 8 May 9, 2024
@sfc-gh-erojaslizano
SNOW-1360070 upgrade docker container to centOS8 dotnet 8
20697a8 
- Upgrade docker file to build Ubuntu 20.04  with dotnet 8 framework
- Update jenkins file to reference new container
- Update .csproj to compile with dotnet 8
@sfc-gh-erojaslizano sfc-gh-erojaslizano marked this pull request as ready for review May 13, 2024 19:40
@sfc-gh-erojaslizano sfc-gh-erojaslizano requested a review from a team as a code owner May 13, 2024 19:40
@codecov Codecov
Copy link

codecov bot commented May 14, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.74%. Comparing base (15f4c55) to head (a346641).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #940      +/-   ##
==========================================
+ Coverage   84.67%   84.74%   +0.07%     
==========================================
  Files          89       89              
  Lines        9702     9709       +7     
  Branches      920      921       +1     
==========================================
+ Hits         8215     8228      +13     
+ Misses       1259     1253       -6     
  Partials      228      228

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

sfc-gh-dstempniak
sfc-gh-dstempniak approved these changes May 15, 2024
View reviewed changes
Copy link
Collaborator

@sfc-gh-dstempniak sfc-gh-dstempniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfc-gh-erojaslizano sfc-gh-erojaslizano merged commit abb5c4a into master May 15, 2024
35 checks passed
@sfc-gh-erojaslizano sfc-gh-erojaslizano deleted the update-to-dotnet-8 branch May 15, 2024 16:04
@github-actions github-actions bot locked and limited conversation to collaborators May 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-dstempniak sfc-gh-dstempniak sfc-gh-dstempniak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-erojaslizano @sfc-gh-dstempniak