Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1053935: Support for double quote character in delimited identifier. #926

Merged
merged 1 commit into from
Apr 26, 2024
Merged

SNOW-1053935: Support for double quote character in delimited identifier. #926

merged 1 commit into from
Apr 26, 2024

Conversation

sfc-gh-jmartinezramirez
Copy link
Collaborator

@sfc-gh-jmartinezramirez sfc-gh-jmartinezramirez commented Apr 22, 2024 •
edited
Loading

Description

Support for double quote character in delimited identifier.

Checklist

  • Code compiles correctly
  • Code is formatted according to Coding Conventions
  • Created tests which fail without the change (if possible)
  • All tests passing (dotnet test)
  • Extended the README / documentation, if necessary
  • Provide JIRA issue id (if possible) or GitHub issue id in PR name

@sfc-gh-jmartinezramirez sfc-gh-jmartinezramirez changed the title Support for double quote character in delimited identifier. SNOW-1053935 Support for double quote character in delimited identifier. Apr 22, 2024
@sfc-gh-jmartinezramirez sfc-gh-jmartinezramirez changed the title SNOW-1053935 Support for double quote character in delimited identifier. SNOW-1053935: Support for double quote character in delimited identifier. Apr 22, 2024
@sfc-gh-jmartinezramirez sfc-gh-jmartinezramirez force-pushed the SNOW-1053935-fixquotedobjectvalues branch from 5d7abcc to 357d4a6 Compare April 23, 2024 13:44
@codecov Codecov
Copy link

codecov bot commented Apr 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.67%. Comparing base (14cf8a5) to head (357d4a6).

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #926      +/-   ##
==========================================
+ Coverage   84.66%   84.67%   +0.01%     
==========================================
  Files          89       89              
  Lines        9694     9702       +8     
  Branches      919      920       +1     
==========================================
+ Hits         8207     8215       +8     
  Misses       1259     1259              
  Partials      228      228

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfc-gh-jmartinezramirez sfc-gh-jmartinezramirez marked this pull request as ready for review April 23, 2024 14:17
@sfc-gh-jmartinezramirez sfc-gh-jmartinezramirez requested a review from a team as a code owner April 23, 2024 14:17
@sfc-gh-jmartinezramirez sfc-gh-jmartinezramirez merged commit 15f4c55 into master Apr 26, 2024
26 checks passed
@sfc-gh-jmartinezramirez sfc-gh-jmartinezramirez deleted the SNOW-1053935-fixquotedobjectvalues branch April 26, 2024 16:22
@github-actions github-actions bot locked and limited conversation to collaborators Apr 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-mhofman sfc-gh-mhofman sfc-gh-mhofman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-jmartinezramirez @sfc-gh-mhofman