Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pool/snow 860872 connection pool update from master #922

Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
81 commits
Select commit Hold shift + click to select a range
62f2206
Bumped up DotNet connector PATCH version from 2.1.2 to 2.1.3 (#811)
sfc-gh-kdama Nov 14, 2023
1a0809a
SNOW-979340 added description how to enable Arrow (#822)
sfc-gh-dstempniak Nov 30, 2023
2dce725
add lock on qcc to fix sync issue (#814)
Nov 30, 2023
ecdefc6
SNOW-944715 Validate account domain (#820)
sfc-gh-knozderko Dec 1, 2023
614cd7d
SNOW-982481: Sync MacOS time (#826)
sfc-gh-pbulawa Dec 4, 2023
68edb52
PATCH: Bumped up DotNet connector PATCH version from 2.1.3 to 2.1.4 (…
sfc-gh-knozderko Dec 4, 2023
3710031
SNOW-974746 document that we currently do not support bind variables …
sfc-gh-dszmolka Dec 4, 2023
645659a
SNOW-984600 Avoid closing expired sessions synchronously with obtaine…
sfc-gh-knozderko Dec 13, 2023
3ccdab3
SNOW-982481 Drop obsolete time sync for macos builds (#833)
sfc-gh-pfus Dec 14, 2023
49cb77d
SNOW-961434 Fix usage of insecure mode in connection parameters (#832)
sfc-gh-knozderko Dec 15, 2023
e3a44ac
Revert "SNOW-984600 Avoid closing expired sessions synchronously with…
sfc-gh-knozderko Dec 15, 2023
aaa32fd
PATCH: Bumped up DotNet connector PATCH version from 2.1.4 to 2.1.5 (…
sfc-gh-knozderko Dec 15, 2023
5e12bbb
SNOW-984600 Avoid closing expired sessions synchronously with obtaine…
sfc-gh-knozderko Dec 20, 2023
1683d66
SNOW-829779: Strong Name assembly preparation (#843)
sfc-gh-pbulawa Jan 2, 2024
fa1b879
SNOW-968741: Arrow performance optimizations (#831)
sfc-gh-pbulawa Jan 3, 2024
079be0f
SNOW-1005621: [Snyk] Security upgrade System.IdentityModel.Tokens.Jwt…
sfc-gh-snowflakedb-snyk-sa Jan 11, 2024
a6f5261
SNOW-993556: Replace underscores with hyphen (#848)
sfc-gh-pbulawa Jan 12, 2024
7d478f0
MINOR: Bumped up DotNet connector MINOR version from 2.1.5 to 2.2.0 (…
sfc-gh-knozderko Jan 16, 2024
fa09941
SNOW-955536: Multiple SAML Integration (#852)
sfc-gh-ext-simba-lf Jan 23, 2024
e517022
SNOW-969717: Add tests for LOB (#856)
sfc-gh-ext-simba-lf Feb 1, 2024
bd5d8da
SNOW-990111: Add easy logging improvements (#849)
sfc-gh-ext-simba-lf Feb 5, 2024
80bfb2c
SNOW-1009042: Replace Portable.BouncyCastle with BouncyCastle.Cryptog…
sfc-gh-pbulawa Feb 8, 2024
9da3d62
SNOW-990111 Easy Logging more tests and permission check fix (#862)
sfc-gh-knozderko Feb 8, 2024
a1f1d6f
SNOW-916949: Fix Okta retry for SSO/SAML endpoints (#865)
sfc-gh-ext-simba-lf Feb 12, 2024
6be56bb
SNOW-998036: Add check if command text is set before executing (#861)
sfc-gh-ext-simba-lf Feb 14, 2024
9d61e81
SNOW-850068: Remove deprecated parser and downloader (#770)
sfc-gh-pbulawa Feb 15, 2024
fd193e1
SNOW-950923 fix to provide QueryID for failures during GET/PUT file o…
sfc-gh-mhofman Feb 21, 2024
22871b5
SNOW-950923 Flaky test fix (#870)
sfc-gh-mhofman Feb 21, 2024
a868910
SNOW-990111 easy logging driver directory + Mono.Unix (#868)
sfc-gh-knozderko Feb 22, 2024
cfd01fa
SNOW-1111018: Update area in JIRA integration (#872)
sfc-gh-pbulawa Feb 26, 2024
011c831
SNOW-990111 Update easy logging documentation (#875)
sfc-gh-knozderko Feb 26, 2024
78f945a
MAJOR: Bumped up DotNet connector MAJOR version from 2.2.0 to 3.0.0 (…
sfc-gh-knozderko Feb 26, 2024
a072afd
SNOW-920994 add configuration for tests on jenkins (#859)
sfc-gh-akolodziejczyk Feb 28, 2024
5ecb4fa
SNOW-1175042 move regression tests parameters to parameters-local (#878)
sfc-gh-akolodziejczyk Feb 29, 2024
ee843a4
SNOW-1156105 update issue owner and component (#881)
sfc-gh-dszmolka Mar 4, 2024
f24b342
Update README.md for Easy Logging (#886)
sfc-gh-mheavin Mar 11, 2024
7ea8366
SNOW-1206259 Handle OKTA Auth invalid responses more gracefully (#884)
sfc-gh-mhofman Mar 13, 2024
4d85588
SNOW-1232318 fix account name validation (#890)
sfc-gh-knozderko Mar 13, 2024
a25f8c5
SNOW-825595: Update setup instruction for non-Windows environment (#885)
sfc-gh-ext-simba-lf Mar 19, 2024
8fa5df5
SNOW-1230345 Fix to support quoted values in object connection proper…
sfc-gh-jmartinezramirez Mar 20, 2024
5aec6b4
SNOW-817091: Async execution (#887)
sfc-gh-ext-simba-lf Mar 26, 2024
ee0cdaa
SNOW-817091 async executions documentation (#896)
sfc-gh-knozderko Mar 26, 2024
0303514
MINOR: Bumped up DotNet connector MINOR version from 3.0.0 to 3.1.0 (…
sfc-gh-knozderko Mar 27, 2024
ac0860f
SNOW-979288: Add explicit DbType Parameter assignment (#889)
sfc-gh-ext-simba-lf Apr 1, 2024
a302e0f
Fix coding conventions PR template (#905)
sfc-gh-knozderko Apr 3, 2024
dfba44e
SNOW-1271212 Fixed values uploaded to stage for bindings exceeding CL…
sfc-gh-mhofman Apr 4, 2024
e092835
SNOW-977565: Added start and end symbol to match full regex to bypass…
sfc-gh-jmartinezramirez Apr 4, 2024
aa5b101
SNOW-1293828 Updated security policy (#904)
sfc-gh-mhofman Apr 4, 2024
b703f93
SNOW-1168205 iceberg table compliance testing (#908)
sfc-gh-mhofman Apr 15, 2024
46e496a
[SNOW-921048]Add linter action (#892)
sfc-gh-erojaslizano Apr 16, 2024
47235fb
[SNOW-1313929] Add https to endpoints without it (#914)
sfc-gh-erojaslizano Apr 17, 2024
142911a
Merge branch 'master' into pool/SNOW-860872-connection-pool
sfc-gh-knozderko Apr 18, 2024
8e15437
maxRetryTimeout as TimeSpan
sfc-gh-knozderko Apr 19, 2024
a5b1839
make build work
sfc-gh-knozderko Apr 19, 2024
7840223
make tests work
sfc-gh-knozderko Apr 19, 2024
4f0f1a3
tests for isExpired
sfc-gh-knozderko Apr 19, 2024
12b6bf0
closing connections test
sfc-gh-knozderko Apr 19, 2024
d821a37
some testing
sfc-gh-knozderko Apr 19, 2024
678554c
retry flaky test
sfc-gh-knozderko Apr 19, 2024
5d2f1cb
set application for failing tests
sfc-gh-knozderko Apr 19, 2024
c4dfd2e
fix TestLoginWithMaxRetryReached test
sfc-gh-knozderko Apr 22, 2024
79dd04a
fix retries on tests performance results
sfc-gh-knozderko Apr 22, 2024
9830574
retry TestLoginTimeout
sfc-gh-knozderko Apr 22, 2024
d11aaf5
debug get query status
sfc-gh-knozderko Apr 22, 2024
9a63865
more debugging
sfc-gh-knozderko Apr 22, 2024
fbdaa42
more debug
sfc-gh-knozderko Apr 22, 2024
a8815d1
application for failing test
sfc-gh-knozderko Apr 22, 2024
91d7447
more debugging
sfc-gh-knozderko Apr 22, 2024
5e9a900
retry on TestLoginTimeoutWithRetryTimeoutLesserThanConnectionTimeout
sfc-gh-knozderko Apr 22, 2024
ff1515f
disablePooling in some tests for getting query status
sfc-gh-knozderko Apr 22, 2024
74f55b9
testing if fails
sfc-gh-knozderko Apr 23, 2024
b988e00
testing if works
sfc-gh-knozderko Apr 23, 2024
0fbf9df
testing
sfc-gh-knozderko Apr 23, 2024
3a3f702
test if works
sfc-gh-knozderko Apr 23, 2024
78e9c96
ingoring more tests
sfc-gh-knozderko Apr 23, 2024
4ecd4c6
testing SFDbCommandIT
sfc-gh-knozderko Apr 23, 2024
0f05d05
do not return mocked connections to pool
sfc-gh-knozderko Apr 23, 2024
9cbb66a
uningore tests
sfc-gh-knozderko Apr 23, 2024
e0ac1fb
revert debugging
sfc-gh-knozderko Apr 23, 2024
d8b3be2
Make command IT not interfere with each other
sfc-gh-knozderko Apr 23, 2024
0ba934a
remove debugging
sfc-gh-knozderko Apr 23, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
61 changes: 61 additions & 0 deletions .EditorConfig
Original file line number Diff line number Diff line change
@@ -0,0 +1,61 @@
root = true
# All files
[*.*]
indent_style = space
indent_size = 4
insert_final_newline = true
trim_trailing_whitespace = true
charset = utf-8
max_line_length=150

# Interfaces should start with I and PascalCase
dotnet_naming_rule.interfaces_begin_with_I.severity = warning
dotnet_naming_rule.interfaces_begin_with_I.symbols = interfaces
dotnet_naming_rule.interfaces_begin_with_I.style = prefix_and_pascal_case
dotnet_naming_rule.interfaces_begin_with_I.required_prefix = I
dotnet_naming_symbols.interfaces.applicable_kinds = interface
dotnet_diagnostic.interfaces_begin_with_I.severity = warning
dotnet_diagnostic.interfaces_begin_with_I.enabled = true

# Static fields should start with _s
dotnet_naming_rule.static_fields_begin_with_s.severity = warning
dotnet_naming_rule.static_fields_begin_with_s.symbols = static_fields
dotnet_naming_rule.static_fields_begin_with_s.style = custom
dotnet_naming_rule.static_fields_begin_with_s.custom_recommended_prefix = _r
dotnet_naming_rule.static_fields_begin_with_s.required_prefix = _r
dotnet_naming_rule.static_fields_begin_with_s.capitalization = camel_case
dotnet_naming_symbols.static_fields.applicable_kinds = field
dotnet_naming_symbols.static_fields.applicable_accessibilities = public, internal, private, protected, protected_internal
dotnet_naming_symbols.static_fields.required_modifiers = static
dotnet_diagnostic.static_fields_begin_with_s.severity = warning
dotnet_diagnostic.static_fields_begin_with_s.enabled = true

# Enforce use of Pascal case in enums, classes, const and methods
dotnet_naming_rule.enforce_pascal_case.severity = suggestion
dotnet_naming_rule.enforce_pascal_case.symbols = methods, enums, consts, public_methods, public_classes
dotnet_naming_rule.enforce_pascal_case.style = pascal_case
dotnet_naming_symbols.methods.applicable_kinds = method
dotnet_naming_symbols.enums.applicable_kinds = enum
dotnet_naming_symbols.consts.applicable_kinds = field
dotnet_naming_symbols.consts.applicable_modifiers = const
dotnet_naming_symbols.public_methods.applicable_kinds = method
dotnet_naming_symbols.public_methods.applicable_accessibilities = public
dotnet_naming_symbols.public_classes.applicable_kinds = class
dotnet_naming_symbols.public_classes.applicable_accessibilities = public
dotnet_diagnostic.enforce_pascal_case.severity = suggestion
dotnet_diagnostic.enforce_pascal_case.enabled = true

# private and internal members should start with underscore
dotnet_naming_rule.private_and_internal_members_start_with_underscore.severity = warning
dotnet_naming_rule.private_and_internal_members_start_with_underscore.symbols = private_fields, internal_fields, private_properties, internal_properties, private_methods, internal_methods
dotnet_naming_rule.private_and_internal_members_start_with_underscore.style = underscore_prefix
dotnet_naming_symbols.private_fields.applicable_kinds = field
dotnet_naming_symbols.internal_fields.applicable_kinds = field
dotnet_naming_symbols.private_properties.applicable_kinds = property
dotnet_naming_symbols.internal_properties.applicable_kinds = property
dotnet_naming_symbols.private_methods.applicable_kinds = method
dotnet_naming_symbols.internal_methods.applicable_kinds = method
dotnet_naming_symbols.private_methods.applicable_accessibilities = private
dotnet_naming_symbols.internal_methods.applicable_accessibilities = internal
dotnet_diagnostic.private_and_internal_members_start_with_underscore.severity = warning
dotnet_diagnostic.private_and_internal_members_start_with_underscore.enabled = true
4 changes: 2 additions & 2 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@ Please explain the changes you made here.

### Checklist
- [ ] Code compiles correctly
- [ ] Code is formatted according to [Coding Conventions](../CodingConventions.md)
- [ ] Code is formatted according to [Coding Conventions](../blob/master/CodingConventions.md)
- [ ] Created tests which fail without the change (if possible)
- [ ] All tests passing (`dotnet test`)
- [ ] Extended the README / documentation, if necessary
- [ ] Provide JIRA issue id (if possible) or GitHub issue id in PR name
- [ ] Provide JIRA issue id (if possible) or GitHub issue id in PR name
2 changes: 1 addition & 1 deletion .github/repo_meta.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
point_of_contact: @snowflakedb/client
production: true
code_owners_file_present: false
jira_area: Snowpark: Application Development Ecosystem
jira_area: Developer Platform
2 changes: 1 addition & 1 deletion .github/workflows/jira_issue.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ jobs:
summary: '${{ github.event.issue.title }}'
description: |
${{ github.event.issue.body }} \\ \\ _Created from GitHub Action_ for ${{ github.event.issue.html_url }}
fields: '{ "customfield_11401": {"id": "14583"}, "assignee": {"id": "61027a219798100070592b20"} }'
fields: '{ "customfield_11401": {"id": "14723"}, "assignee": {"id": "712020:3c0352b5-63f7-4e26-9afe-38f6f9f0f4c5"}, "components":[{"id":"19287"}] }'

- name: Update GitHub Issue
uses: ./jira/gajira-issue-update
Expand Down
43 changes: 43 additions & 0 deletions .github/workflows/linter.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
name: Code standards check

# Triggers the workflow on pull request events but only for the master branch
on:
pull_request:
branches: [ master ]
workflow_dispatch:
inputs:
logLevel:
default: warning
description: "Log level"
required: true
tags:
description: "Linter"
required: false

concurrency:
# older builds for the same pull request number or branch should be cancelled
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
cancel-in-progress: true

env:
DOTNET_VERSION: 6.0
DOTNET_LEGACY_VERSION: 4.7.1

jobs:
run-linter:
name: Run linter
runs-on: windows-latest
steps:
- name: Check out Git repository
uses: actions/checkout@v3
- name: Set up .NET
uses: actions/setup-dotnet@v1
with:
dotnet-version: "6.0.x"
dotnet-quality: 'ga'
- name: Run linters
uses: wearerequired/lint-action@v2
with:
dotnet_format: true
continue_on_error: true
check_name: ${linter} run
3 changes: 2 additions & 1 deletion .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,8 @@ jobs:
dotnet: ['net6.0', 'net472', 'net471']
cloud_env: ['AZURE', 'GCP', 'AWS']
steps:
- uses: actions/checkout@v3
- name: Checkout code
uses: actions/checkout@v3
- name: Setup Dotnet
uses: actions/setup-dotnet@v3
with:
Expand Down
3 changes: 3 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -309,3 +309,6 @@ whitesource/
Snowflake.Data.Tests/macos_*_performance.csv
Snowflake.Data.Tests/windows_*_performance.csv
Snowflake.Data.Tests/unix_*_performance.csv

# Ignore Mac files
**/.DS_Store
67 changes: 67 additions & 0 deletions Jenkinsfile
Original file line number Diff line number Diff line change
@@ -0,0 +1,67 @@
import groovy.json.JsonOutput


timestamps {
node('regular-memory-node') {
stage('checkout') {
scmInfo = checkout scm
println("${scmInfo}")
env.GIT_BRANCH = scmInfo.GIT_BRANCH
env.GIT_COMMIT = scmInfo.GIT_COMMIT
}

stage('Build') {
withCredentials([
usernamePassword(credentialsId: '063fc85b-62a6-4181-9d72-873b43488411', usernameVariable: 'AWS_ACCESS_KEY_ID', passwordVariable: 'AWS_SECRET_ACCESS_KEY'),
string(credentialsId: 'a791118f-a1ea-46cd-b876-56da1b9bc71c',variable: 'NEXUS_PASSWORD')
]) {
sh '''\
|#!/bin/bash -e
|export GIT_BRANCH=${GIT_BRANCH}
|export GIT_COMMIT=${GIT_COMMIT}
|$WORKSPACE/ci/build.sh
'''.stripMargin()
}
}
params = [
string(name: 'svn_revision', value: 'main'),
string(name: 'branch', value: 'main'),
string(name: 'client_git_commit', value: scmInfo.GIT_COMMIT),
string(name: 'client_git_branch', value: scmInfo.GIT_BRANCH),
string(name: 'TARGET_DOCKER_TEST_IMAGE', value: 'dotnet-centos7-net6'),
string(name: 'parent_job', value: env.JOB_NAME),
string(name: 'parent_build_number', value: env.BUILD_NUMBER)
]
stage('Test') {
build job: 'RT-LanguageDotnet-PC',parameters: params
}
}
}


pipeline {
agent { label 'regular-memory-node' }
options { timestamps() }
environment {
COMMIT_SHA_LONG = sh(returnStdout: true, script: "echo \$(git rev-parse " + "HEAD)").trim()

// environment variables for semgrep_agent (for findings / analytics page)
// remove .git at the end
// remove SCM URL + .git at the end

BASELINE_BRANCH = "${env.CHANGE_TARGET}"
}
stages {
stage('Checkout') {
steps {
checkout scm
}
}
}
}

def wgetUpdateGithub(String state, String folder, String targetUrl, String seconds) {
def ghURL = "https://api.github.com/repos/snowflakedb/snowflake-connector-net/statuses/$COMMIT_SHA_LONG"
def data = JsonOutput.toJson([state: "${state}", context: "jenkins/${folder}",target_url: "${targetUrl}"])
sh "wget ${ghURL} --spider -q --header='Authorization: token $GIT_PASSWORD' --post-data='${data}'"
}
Loading
Loading