Snow 1296059 poc dependencies csproj #919
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #919 +/- ##
==========================================
- Coverage 84.66% 0.00% -84.67%
==========================================
Files 89 89
Lines 9694 9683 -11
Branches 919 917 -2
==========================================
- Hits 8207 0 -8207
- Misses 1259 9682 +8423
+ Partials 228 1 -227 ☔ View full report in Codecov by Sentry. |
This requires using Nuget.exe to be generated using the next command: nuget.exe pack snowflake.data.aws.nuspec -Exclude **
…dependency of nuget cli This package could be generated using the following command dotnet pack Snowflake.Data.AWS.Dependencies.csproj
Move Snowflake logic to Snowflake.Data.Core. Create specific projects for cloud providers dependencies.
sfc-gh-jmartinezramirez
force-pushed
the
SNOW-1296059-poc-dependencies-csproj
branch
from
56ca484 to
46e54d5
Compare
There was a problem hiding this comment.
So how do we keep with this change backward compatibility regarding Snowflake.Data driver (the full blown with all the deps)?
There was a problem hiding this comment.
Closing this PR, current proposal updated #929
This will have the Snowflake.Data package with full dependencies from cloud providers
sfc-gh-jmartinezramirez
deleted the
SNOW-1296059-poc-dependencies-csproj
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This only to review changes for poc
Checklist
dotnet test)