Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pool/snow 860872 connection pool #913

Closed
wants to merge 8 commits into from

Pool/SNOW-937183 Prevent evicted connections from returning to the po…

7db9d54
Select commit
Loading
Failed to load commit list.
Closed

Pool/snow 860872 connection pool #913

Pool/SNOW-937183 Prevent evicted connections from returning to the po…
7db9d54
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Apr 12, 2024 in 0s

82.49% (-1.07%) compared to 22d32dd

View this Pull Request on Codecov

82.49% (-1.07%) compared to 22d32dd

Details

Codecov Report

Attention: Patch coverage is 94.27609% with 51 lines in your changes are missing coverage. Please review.

Project coverage is 82.49%. Comparing base (22d32dd) to head (7db9d54).
Report is 48 commits behind head on master.

Files Patch % Lines
Snowflake.Data/Core/Session/SessionPool.cs 93.31% 10 Missing and 11 partials ⚠️
...Data/Core/Session/SFSessionHttpClientProperties.cs 90.00% 7 Missing and 3 partials ⚠️
Snowflake.Data/Client/SnowflakeDbConnectionPool.cs 92.85% 2 Missing and 2 partials ⚠️
...flake.Data/Core/Session/SessionOrCreationTokens.cs 82.60% 2 Missing and 2 partials ⚠️
Snowflake.Data/Core/Session/WaitingQueue.cs 92.59% 3 Missing and 1 partial ⚠️
...ion/SessionPropertiesWithDefaultValuesExtractor.cs 96.42% 1 Missing and 2 partials ⚠️
...owflake.Data/Core/Session/ConnectionPoolManager.cs 97.75% 1 Missing and 1 partial ⚠️
...flake.Data/Core/Session/SessionPoolEventHandler.cs 80.00% 2 Missing ⚠️
Snowflake.Data/Core/Session/SFSession.cs 93.75% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #913      +/-   ##
==========================================
- Coverage   83.56%   82.49%   -1.07%     
==========================================
  Files          89      104      +15     
  Lines        9155     9916     +761     
  Branches      837      917      +80     
==========================================
+ Hits         7650     8180     +530     
- Misses       1278     1488     +210     
- Partials      227      248      +21

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov