-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pool/SNOW-937183 Prevent evicted connections from returning to the pool #912
Merged
sfc-gh-knozderko
merged 7 commits into
pool/SNOW-860872-connection-pool
from
pool/SNOW-937183_evict_connection
Apr 12, 2024
Merged
Pool/SNOW-937183 Prevent evicted connections from returning to the pool #912
sfc-gh-knozderko
merged 7 commits into
pool/SNOW-860872-connection-pool
from
pool/SNOW-937183_evict_connection
Apr 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## pool/SNOW-860872-connection-pool #912 +/- ##
====================================================================
+ Coverage 82.37% 82.49% +0.12%
====================================================================
Files 104 104
Lines 9876 9916 +40
Branches 912 917 +5
====================================================================
+ Hits 8135 8180 +45
+ Misses 1491 1488 -3
+ Partials 250 248 -2 ☔ View full report in Codecov by Sentry. |
sfc-gh-pbulawa
approved these changes
Apr 10, 2024
sfc-gh-mhofman
approved these changes
Apr 11, 2024
sfc-gh-knozderko
merged commit Apr 12, 2024
7db9d54
into
pool/SNOW-860872-connection-pool
21 checks passed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Prevent evicted connections from returning to the pool
Checklist
dotnet test
)