Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pool/SNOW-937183 Prevent evicted connections from returning to the pool #912

Conversation

sfc-gh-knozderko
Copy link
Collaborator

Description

Prevent evicted connections from returning to the pool

Checklist

  • Code compiles correctly
  • Code is formatted according to Coding Conventions
  • Created tests which fail without the change (if possible)
  • All tests passing (dotnet test)
  • Extended the README / documentation, if necessary
  • Provide JIRA issue id (if possible) or GitHub issue id in PR name

@sfc-gh-knozderko sfc-gh-knozderko requested a review from a team as a code owner April 8, 2024 13:33
Copy link

codecov bot commented Apr 8, 2024

Codecov Report

Attention: Patch coverage is 95.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 82.49%. Comparing base (b842cbd) to head (b765c1b).

Files Patch % Lines
Snowflake.Data/Core/Session/SessionPool.cs 85.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@                         Coverage Diff                          @@
##           pool/SNOW-860872-connection-pool     #912      +/-   ##
====================================================================
+ Coverage                             82.37%   82.49%   +0.12%     
====================================================================
  Files                                   104      104              
  Lines                                  9876     9916      +40     
  Branches                                912      917       +5     
====================================================================
+ Hits                                   8135     8180      +45     
+ Misses                                 1491     1488       -3     
+ Partials                                250      248       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Snowflake.Data/Client/SnowflakeDbConnection.cs Outdated Show resolved Hide resolved
Snowflake.Data/Client/SnowflakeDbConnection.cs Outdated Show resolved Hide resolved
Snowflake.Data/Client/SnowflakeDbConnection.cs Outdated Show resolved Hide resolved
Snowflake.Data/Core/Session/SessionPool.cs Show resolved Hide resolved
Snowflake.Data/Core/Session/SessionPool.cs Show resolved Hide resolved
Snowflake.Data/Core/Session/SessionPool.cs Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@sfc-gh-knozderko sfc-gh-knozderko merged commit 7db9d54 into pool/SNOW-860872-connection-pool Apr 12, 2024
21 checks passed
@sfc-gh-knozderko sfc-gh-knozderko deleted the pool/SNOW-937183_evict_connection branch April 12, 2024 10:07
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants