Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-817091: Async execution #887

Merged
merged 48 commits into from
Mar 26, 2024
Merged

SNOW-817091: Async execution #887

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
48 commits
Select commit Hold shift + click to select a range
727b460
SNOW-817091: Add async execution
sfc-gh-ext-simba-lf Mar 9, 2024
812cba0
SNOW-817091: Add tests
sfc-gh-ext-simba-lf Mar 9, 2024
3810211
SNOW-817091: Fix session closing issue
sfc-gh-ext-simba-lf Mar 9, 2024
03d7b64
SNOW-817091: Mark nonparallelizable
sfc-gh-ext-simba-lf Mar 9, 2024
97904a9
Revert last commit
sfc-gh-ext-simba-lf Mar 9, 2024
eae1e7d
SNOW-817091: Add check for NET Framework
sfc-gh-ext-simba-lf Mar 9, 2024
e52aded
Remove empty line
sfc-gh-ext-simba-lf Mar 15, 2024
c064688
Include uppercase letters in uuid regex
sfc-gh-ext-simba-lf Mar 15, 2024
b0827ff
Add short description for async mode
sfc-gh-ext-simba-lf Mar 16, 2024
d9288ab
Add check for PUT/GET in async exec mode
sfc-gh-ext-simba-lf Mar 16, 2024
69c8a41
Add GET command to test
sfc-gh-ext-simba-lf Mar 18, 2024
95cd938
Add check for cancellation while getting results
sfc-gh-ext-simba-lf Mar 18, 2024
20518fe
Replace GetQueryStatus with GetQueryStatusAsync
sfc-gh-ext-simba-lf Mar 18, 2024
6ce4a8a
Refactor async exec retry into one function
sfc-gh-ext-simba-lf Mar 18, 2024
e4beae6
Fix indent
sfc-gh-ext-simba-lf Mar 19, 2024
60335ec
Replace task with await
sfc-gh-ext-simba-lf Mar 19, 2024
78b0272
Replace task with await
sfc-gh-ext-simba-lf Mar 19, 2024
bc20b8a
Fix async test for .NET Framework
sfc-gh-ext-simba-lf Mar 19, 2024
ad8d40f
Fix async test for .NET Framework
sfc-gh-ext-simba-lf Mar 19, 2024
c94a51d
Use PascalCase for enum values
sfc-gh-ext-simba-lf Mar 19, 2024
c899f26
Remove comment about QueryDTO
sfc-gh-ext-simba-lf Mar 19, 2024
d874805
Remove AsyncQueries property and related functions
sfc-gh-ext-simba-lf Mar 19, 2024
4a5cb1d
Add missing indent
sfc-gh-ext-simba-lf Mar 20, 2024
0c3fbb5
Break while loop after a number of status retries
sfc-gh-ext-simba-lf Mar 20, 2024
b9a58a3
Rename test
sfc-gh-ext-simba-lf Mar 20, 2024
912f4a2
Use different sessions for the test
sfc-gh-ext-simba-lf Mar 20, 2024
a622537
Modify test tag
sfc-gh-ext-simba-lf Mar 21, 2024
21915dc
Assign enum with string values
sfc-gh-ext-simba-lf Mar 21, 2024
7185f79
Re-add check if token is cancelled
sfc-gh-ext-simba-lf Mar 21, 2024
6ec657b
Remove unused imports
sfc-gh-ext-simba-lf Mar 22, 2024
1d7dafb
Create variable for max status retry
sfc-gh-ext-simba-lf Mar 22, 2024
d4994d2
Merge branch 'master' of https://github.com/snowflakedb/snowflake-con…
sfc-gh-ext-simba-lf Mar 22, 2024
ce10981
Refactor QueryStatuses
sfc-gh-ext-simba-lf Mar 22, 2024
198a39b
Refactor QueryStatuses
sfc-gh-ext-simba-lf Mar 22, 2024
6438057
Make comparison case insensitive
sfc-gh-ext-simba-lf Mar 22, 2024
8957d17
Add Unknown status to enum
sfc-gh-ext-simba-lf Mar 23, 2024
293f58d
Add test for GetQueryStatusByStringValue
sfc-gh-ext-simba-lf Mar 23, 2024
29b8149
Replaced Description attribute with StringAttr attribute
sfc-gh-ext-simba-lf Mar 23, 2024
95f0986
Remove unused import
sfc-gh-ext-simba-lf Mar 25, 2024
470907c
Rename parameter
sfc-gh-ext-simba-lf Mar 25, 2024
d49d83d
Split test case into positive/negative cases
sfc-gh-ext-simba-lf Mar 25, 2024
e6ab842
Remove Unknown enum and refactor GetQueryStatusByStringValue
sfc-gh-ext-simba-lf Mar 25, 2024
73358b1
Refactor async query retry into its own class
sfc-gh-ext-simba-lf Mar 25, 2024
e1c50b6
Add util functions for user to check query status is still running or…
sfc-gh-ext-simba-lf Mar 25, 2024
3801171
Remove public constructor
sfc-gh-ext-simba-lf Mar 25, 2024
d05c248
Revert removing newline
sfc-gh-ext-simba-lf Mar 25, 2024
1877755
Add missing test comment
sfc-gh-ext-simba-lf Mar 25, 2024
91f9ac8
Mark class internal and use static instance
sfc-gh-ext-simba-lf Mar 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Snowflake.Data.Tests/IntegrationTests/SFConnectionPoolIT.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,7 +333,7 @@ void ThreadProcess2(string connstr)

Thread.Sleep(5000);
SFStatement statement = new SFStatement(conn1.SfSession);
SFBaseResultSet resultSet = statement.Execute(0, "select 1", null, false);
SFBaseResultSet resultSet = statement.Execute(0, "select 1", null, false, false);
Assert.AreEqual(true, resultSet.Next());
Assert.AreEqual("1", resultSet.GetString(0));
SnowflakeDbConnectionPool.ClearAllPools();
Expand Down
Loading
Loading