Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1206259 Handle OKTA Auth invalid responses more gracefully #884

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

sfc-gh-mhofman
Copy link
Collaborator

@sfc-gh-mhofman sfc-gh-mhofman commented Mar 6, 2024

Description

Native OKTA SSO Authn improvements of error handling.

Checklist

  • Code compiles correctly
  • Code is formatted according to Coding Conventions
  • Created tests which fail without the change (if possible)
  • All tests passing (dotnet test)
  • Extended the README / documentation, if necessary
  • Provide JIRA issue id (if possible) or GitHub issue id in PR name

@sfc-gh-mhofman sfc-gh-mhofman requested a review from a team as a code owner March 6, 2024 15:29
Copy link

codecov bot commented Mar 6, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 84.17%. Comparing base (ee843a4) to head (c982f4b).
Report is 1 commits behind head on master.

Files Patch % Lines
...flake.Data/Core/Authenticator/OktaAuthenticator.cs 88.88% 5 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #884      +/-   ##
==========================================
+ Coverage   84.11%   84.17%   +0.05%     
==========================================
  Files          88       88              
  Lines        9401     9392       -9     
  Branches      885      885              
==========================================
- Hits         7908     7906       -2     
+ Misses       1260     1254       -6     
+ Partials      233      232       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfc-gh-mhofman sfc-gh-mhofman force-pushed the SNOW-1206259_npe_protect_okta_authenticator branch from e829441 to e8ec9e0 Compare March 7, 2024 10:50
@sfc-gh-mhofman sfc-gh-mhofman force-pushed the SNOW-1206259_npe_protect_okta_authenticator branch from e8ec9e0 to c982f4b Compare March 12, 2024 09:43
@sfc-gh-mhofman sfc-gh-mhofman merged commit 7ea8366 into master Mar 13, 2024
24 checks passed
@sfc-gh-mhofman sfc-gh-mhofman deleted the SNOW-1206259_npe_protect_okta_authenticator branch March 13, 2024 09:19
@github-actions github-actions bot locked and limited conversation to collaborators Mar 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants